Bug 2121063

Summary:	Production RHACM upgrade from v2.4.2 to 2.5.1
Product:	Red Hat Advanced Cluster Management for Kubernetes	Reporter:	mheppler
Component:	App Lifecycle	Assignee:	Feng Xiang <fxiang>
Status:	CLOSED ERRATA	QA Contact:	Almen Ng <almng>
Severity:	urgent	Docs Contact:
Priority:	unspecified
Version:	rhacm-2.5	CC:	amigliet, dho, gsciorti, iamin, mbetti
Target Milestone:	---	Flags:	dho: qe_test_coverage+ bot-tracker-sync: rhacm-2.5.z+
Target Release:	rhacm-2.5.3
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-10-13 19:42:47 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description mheppler 2022-08-24 11:22:22 UTC

Description of the problem:

After upgrade to v2.5.1 from v2.4.2, there is a RHACM application that wants to deploy on the target clusters OpenShift GitOps/Argo CD applications and applicationsets, but it fails with the following error:

```
Error: This application has no matched subscription. Make sure the subscription match selector spec.selector.matchExpressions exists and matches a Subscription resource created in the namespace.
```

This application worked on RHACM version 2.4.x and earlier.
From the error above, it seems to me that it is misinterpreting the type of resource, expecting an application Argo CD to have an associated subscription.
An Argo CD application does not have the attribute `spec.selector.matchExpressions`.
All other resources, except the kind Application and Applicationsets, are deployed correctly.


Release version:

ACM 2.5.1

Operator snapshot version:

OCP version:

Browser Info:

Steps to reproduce:
1.
2.
3.

Actual results:

Expected results:

Additional info:

namespaces/open-cluster-management/pods/multicluster-operators-application-b67f6ccc7-mtc2w


./namespaces/open-cluster-management/pods/multicluster-operators-application-b67f6ccc7-mtc2w/multicluster-operators-application/multicluster-operators-application/logs/current.log:2022-08-23T08:30:57.037013402Z E0823 08:30:57.036971       1 application_controller.go:235] Error returned when updating application :Operation cannot be fulfilled on applications.app.k8s.io "argocd": the object has been modified; please apply your changes to the latest version and try againinstance:openshift-gitops/argocd
./namespaces/open-cluster-management/pods/multicluster-operators-application-b67f6ccc7-mtc2w/multicluster-operators-application/multicluster-operators-application/logs/current.log:2022-08-23T08:34:32.537520749Z E0823 08:34:32.537472       1 application_controller.go:235] Error returned when updating application :Operation cannot be fulfilled on applications.app.k8s.io "argocd": the object has been modified; please apply your changes to the latest version and try againinstance:openshift-gitops/argocd

Comment 3 bot-tracker-sync 2022-08-31 21:04:01 UTC

G2Bsync 1233395339 comment 
 fxiang1 Wed, 31 Aug 2022 20:36:00 UTC 
 G2Bsync
Fix delivered to 2.7. Still waiting for 2.5.z and 2.6.z streams open so I can cherry pick the fixes to those streams.

Comment 4 bot-tracker-sync 2022-09-15 15:46:56 UTC

G2Bsync 1248176735 comment 
 fxiang1 Thu, 15 Sep 2022 14:24:04 UTC 
 G2Bsync
Fix cherry picked to the 2.5.z stream. Now just waiting for the 2.6.z stream to open up.

Comment 5 bot-tracker-sync 2022-09-26 19:44:19 UTC

G2Bsync 1258506590 comment 
 fxiang1 Mon, 26 Sep 2022 19:20:43 UTC 
 G2Bsync
Fix cherry picked to the 2.6.z stream.

Comment 6 Ishmam Amin 2022-10-04 17:46:17 UTC

Created attachment 1916010 [details]
ApplicationSet and Application deploys successfully

In ACM 2.5.3, the ApplicationSet and Application resource topology deploys as expected with no errors present

Comment 7 Ishmam Amin 2022-10-05 19:29:17 UTC

Verified on Fresh install environment and Y-upgrade environment

Comment 12 errata-xmlrpc 2022-10-13 19:42:47 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: Red Hat Advanced Cluster Management 2.5.3 security fixes and bug fixes), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:6954