Bug 2121232

Summary:	Please add lfs support to the git-clone clustertask
Product:	Red Hat OpenShift Pipelines	Reporter:	Jeff <jgustafson>
Component:	pipelines	Assignee:	Vincent Demeester <vdemeest>
Status:	ASSIGNED ---	QA Contact:	Ruchir Garg <rgarg>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	1.7	CC:	cboudjna, kbaig, nikthoma, pgarg, rbehera, sashture
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:		Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Jeff 2022-08-24 20:50:38 UTC

Description of problem:
The git-clone task on Tekton hub supports LFS. The git-clone task provided by OpenShift Pipelines does not. Please update the git-clone base image so that it includes git-lfs

Version-Release number of selected component (if applicable):


How reproducible:
Use git-clone task. Files stored with git-lfs are missing. 

Steps to Reproduce:
1. Use git-cline ClusterTask
2. Files are missing that are stored in git-lfs
3.

Actual results:
Missing files.

Expected results:
Files that are stored in git-lfs should be available in the pipeline.

Additional info:

Comment 1 Vincent Demeester 2022-08-25 09:38:45 UTC

Hey Jeff, I think we just need to install git-lfs in the image we ship.
See https://gitlab.cee.redhat.com/tekton/p12n/-/merge_requests/212, will target 1.9 for this.

Comment 2 Jeff 2022-08-25 18:14:44 UTC

(In reply to Vincent Demeester from comment #1)
> Hey Jeff, I think we just need to install git-lfs in the image we ship.
> See https://gitlab.cee.redhat.com/tekton/p12n/-/merge_requests/212, will
> target 1.9 for this.

Yeah, it should be an easy fix. Would you mind referencing the container image/tag in this bugreport when it becomes available? I could use that info to override the one referenced in the ClusterTask definition. In theory, it should work even before 1.9 is released..... or do both of those things happen simultaneously?