Bug 2122024
| Summary: | Review Request: golang-github-cloudflare-circl - CIRCL: Cloudflare Interoperable Reusable Cryptographic Library | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Mikel Olasagasti Uranga <mikel> | ||||
| Component: | Package Review | Assignee: | Maxwell G <maxwell> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | maxwell, package-review | ||||
| Target Milestone: | --- | Flags: | maxwell:
fedora-review+
|
||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2022-09-08 21:42:35 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | 2122023 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
|
Description
Mikel Olasagasti Uranga
2022-08-28 14:52:29 UTC
Fedora-review: https://download.copr.fedorainfracloud.org/results/mikelo2/crypto-specs/fedora-rawhide-x86_64/04772977-golang-github-cloudflare-circl/fedora-review/review.txt Build: https://copr.fedorainfracloud.org/coprs/mikelo2/crypto-specs/build/4772977/ Created attachment 1909682 [details]
Install missing license file
There's a license file in the source tree that you didn't install. Please see the attached patch.
Spec URL: https://mikel.olasagasti.info/tmp/fedora/golang-github-cloudflare-circl.spec SRPM URL: https://mikel.olasagasti.info/tmp/fedora/golang-github-cloudflare-circl-1.2.0-1.fc36.src.rpm Added missing license, good catch. It looks like you forgot to upload the new specfile. It's a cache problem, can you retry? I need to check my webserver to avoid caching specs. (In reply to Mikel Olasagasti Uranga from comment #5) > It's a cache problem, can you retry? I need to check my webserver to avoid > caching specs. Ah. Ctrl+Shift+R works. I am not going to go through the whole fedora-review template, as this package uses go2rpm. - [x] The specfile is sane. - [x] License is correct - [x] Builds successfully in mock - [x] Package is installable (checked by fedora-review) - [x] No relevant rpmlint errors - [x] %check section passes - [x] The latest version is packaged - [x] `%goipath` is set correctly - [-] Binaries don't conflict with binaries already in the distribution - [x] The package complies with the Packaging Guidelines. Package approved! On import, don't forget to do the following: - [ ] Add package to release-monitoring.org - [ ] Give go-sig privileges on package - [ ] Close the review bug by referencing it in the rpm changelog and the Bodhi ticket. If you have time to look at any of my review requests, that would be nice ;). See https://bugzilla.redhat.com/buglist.cgi?component=Package Review&email1=gotmax%40e.email&emailreporter1=1&emailtype1=substring&query_format=advanced&status=NEW Thanks! (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-cloudflare-circl FEDORA-2022-a68b00e6fb has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2022-a68b00e6fb FEDORA-2022-a68b00e6fb has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report. |