Bug 2122174

This bug report has Keywords: Regression or TestBlocker.
Since no regressions or test blockers are allowed between releases, it is also being identified as a blocker for this release. Please resolve ASAP.

FailedQA in 
ovirt-engine-dwh-4.5.5-1.el8ev
ovirt-engine-dwh-setup-4.5.5-1.el8ev
ovirt-engine-4.5.2.5-0.1.el8ev


Now another error is thrown during the setup:
```
...
          The engine should be restarted for Single-Sign-On (SSO) to work. Do this as part of Setup? If not, you will have to do this later by yourself (Yes, No) [Yes]:
[ ERROR ] Failed to execute stage 'Environment customization': write() argument must be str, not bytes
...
```

Stacktrace from the setup log:
```
2022-09-07 16:33:41,054+0200 DEBUG otopi.context context._executeMethod:145 method exception
Traceback (most recent call last):
  File "/usr/lib/python3.6/site-packages/otopi/context.py", line 132, in _executeMethod
    method['method']()
  File "/usr/share/ovirt-engine/setup/bin/../plugins/ovirt-engine-setup/ovirt-engine-grafana-dwh/core/config.py", line 224, in _customization_sso
    f.write(res)
TypeError: write() argument must be str, not bytes
```

Probably caused by this change:
https://github.com/oVirt/ovirt-dwh/pull/49/files#diff-8e84da21999dc564e3890014b4a064b88c98b4ffe6c397492a3e66e6d0e9a082R223

(In reply to Pavel Novotny from comment #2)
> FailedQA in 
> ovirt-engine-dwh-4.5.5-1.el8ev
> ovirt-engine-dwh-setup-4.5.5-1.el8ev
> ovirt-engine-4.5.2.5-0.1.el8ev
> 
> 
> Now another error is thrown during the setup:
> ```
> ...
>           The engine should be restarted for Single-Sign-On (SSO) to work.
> Do this as part of Setup? If not, you will have to do this later by yourself
> (Yes, No) [Yes]:
> [ ERROR ] Failed to execute stage 'Environment customization': write()
> argument must be str, not bytes
> ...
> ```
> 
> Stacktrace from the setup log:
> ```
> 2022-09-07 16:33:41,054+0200 DEBUG otopi.context context._executeMethod:145
> method exception
> Traceback (most recent call last):
>   File "/usr/lib/python3.6/site-packages/otopi/context.py", line 132, in
> _executeMethod
>     method['method']()
>   File
> "/usr/share/ovirt-engine/setup/bin/../plugins/ovirt-engine-setup/ovirt-
> engine-grafana-dwh/core/config.py", line 224, in _customization_sso
>     f.write(res)
> TypeError: write() argument must be str, not bytes
> ```
> 
> Probably caused by this change:
> https://github.com/oVirt/ovirt-dwh/pull/49/files#diff-
> 8e84da21999dc564e3890014b4a064b88c98b4ffe6c397492a3e66e6d0e9a082R223

That's super strange, above error was exactly the reason why I need to create below fix to pass successfully:

https://github.com/oVirt/ovirt-dwh/commit/885d65f0594dee08a48fbe48bdf697de7bcceb6b

Do you still have the env for further investigation?

(In reply to Martin Perina from comment #4)
...
...
> That's super strange, above error was exactly the reason why I need to
> create below fix to pass successfully:
> 
> https://github.com/oVirt/ovirt-dwh/commit/
> 885d65f0594dee08a48fbe48bdf697de7bcceb6b
> 
> Do you still have the env for further investigation?

Environment provided (via chat).
If you need to reproduce the issue life, I can set up clean machines before the engine-setup is executed.

Logged into the env and reproduced.

Still not sure about the root cause, but this workaround makes it pass this point - basically revert one of the two patches in PR 49:

# dnf install -y patch

# curl https://github.com/oVirt/ovirt-dwh/commit/885d65f0594dee08a48fbe48bdf697de7bcceb6b.diff | patch -R /usr/share/ovirt-engine/setup/plugins/ovirt-engine-setup/ovirt-engine-grafana-dwh/core/config.py

To undo the workaround from above comment 6, drop the '-R':

# curl https://github.com/oVirt/ovirt-dwh/commit/885d65f0594dee08a48fbe48bdf697de7bcceb6b.diff | patch /usr/share/ovirt-engine/setup/plugins/ovirt-engine-setup/ovirt-engine-grafana-dwh/core/config.py

After spending some more time, summarizing what I currently know:

1. I think, not sure, that [1], which is part of [2], was needed for a specific flow, which is to run setup on a separate machine and answering 'manual files' about how to access the remote engine. Martin is still looking at this. That is, it was needed to fix some bug X, not really related to current bug.

2. Martin pushed [1] to fix X, but this broke the flow of using 'ssh as root', which is what's in comment 2.

3. I verified that reverting [1] fixed the breakage of root-ssh, but reintroduces a breakage in manual-files. I pushed a revert patch [3].

4. To fix X for both flows, I pushed another patch [4]. I verified both flows with both [3] and [4] successfully.

5. I think, didn't test, that merging only [4] without [3] will break both flows. So once we decide what to do, we should probably update [3] and/or [4] to require/conflict with fixed/broken versions as applicable.

If we do nothing, BTW, another workaround is to use manual-files. That's usually less convenient (but more secure, as it does not require allowing ssh as root to the engine machine from dwh).

[1] https://github.com/oVirt/ovirt-dwh/pull/49/commits/a5a8d7d86a798c39d20fa2145f1f4bd66cfa1143
[2] https://github.com/oVirt/ovirt-dwh/pull/49
[3] https://github.com/oVirt/ovirt-dwh/pull/56
[4] https://github.com/oVirt/ovirt-engine/pull/645

Verified in
ovirt-engine-4.5.3.2-1.el8ev.noarch
ovirt-engine-dwh-4.5.7-1.el8ev.noarch

Running engine-setup on a separate DWH machine and choosing the option "1 - Access remote engine server using ssh as root"
ends up successfully.