Bug 2122946

Summary: Fix for covscan results
Product: Red Hat Enterprise Linux 9 Reporter: Phil Sutter <psutter>
Component: conntrack-toolsAssignee: Phil Sutter <psutter>
Status: CLOSED ERRATA QA Contact: Jianwen Ji <jiji>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 9.2CC: egarver, jiji, shuali
Target Milestone: rcKeywords: Triaged, Upstream
Target Release: 9.2   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: conntrack-tools-1.4.5-17.el9_1 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 2068443 Environment:
Last Closed: 2023-01-23 15:18:04 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 2068443    
Bug Blocks:    

Comment 1 Phil Sutter 2022-08-31 15:06:21 UTC
Upstream commit to backport:

commit 96980c548d3a1aeb07ab6aaef45389efb058a69a
Author: Phil Sutter <phil>
Date:   Wed Aug 31 13:00:52 2022 +0200

    local: Avoid sockaddr_un::sun_path buffer overflow
    
    The array's size in struct sockaddr_un is only UNIX_PATH_MAX and
    according to unix(7), it should hold a null-terminated string. So adjust
    config reader to reject paths of length UNIX_PATH_MAX and above and
    adjust the internal arrays to aid the compiler.
    
    Fixes: f196de88cdd97 ("src: fix strncpy -Wstringop-truncation warnings")
    Signed-off-by: Phil Sutter <phil>

Comment 2 Phil Sutter 2022-09-06 12:43:41 UTC
Filed MR https://gitlab.com/redhat/centos-stream/rpms/conntrack-tools/-/merge_requests/10 but BZ checks still require ITR 9.1.0. So let's wait until 9.2.0 development officially opens.

Comment 16 errata-xmlrpc 2023-01-23 15:18:04 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (conntrack-tools bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2023:0310