Bug 2123435

Summary: Missing files?
Product: [Fedora] Fedora Reporter: Vít Ondruch <vondruch>
Component: nodejs-underscoreAssignee: T.C. Hollingsworth <tchollingsworth>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: mtasaka, tchollingsworth
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: nodejs-underscore-1.13.1-4.fc38 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-01-13 06:01:41 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Vít Ondruch 2022-09-01 16:58:49 UTC
Description of problem:
Checking why coffee-script build fails, there is this error:

~~~
+ ./bin/cake build
node:internal/modules/cjs/loader:499
      throw e;
      ^
[Error: Cannot find module '/builddir/build/BUILD/coffeescript-f26d33d418dcdcfcc6ad3ab774d9cabbf7af659c/node_modules/underscore/underscore-node.cjs'
  at createEsmNotFoundErr (node:internal/modules/cjs/loader:977:15)
  at finalizeEsmResolution (node:internal/modules/cjs/loader:970:15)
  at resolveExports (node:internal/modules/cjs/loader:493:14)
  at Function.Module._findPath (node:internal/modules/cjs/loader:533:31)
  at Function.Module._resolveFilename (node:internal/modules/cjs/loader:942:27)
  at Function.Module._load (node:internal/modules/cjs/loader:804:27)
  at Module.require (node:internal/modules/cjs/loader:1022:19)
  at require (node:internal/modules/cjs/helpers:102:18)
  at Object.<anonymous> (/builddir/build/BUILD/coffeescript-f26d33d418dcdcfcc6ad3ab774d9cabbf7af659c/Cakefile:9:7)
  at Object.<anonymous> (/builddir/build/BUILD/coffeescript-f26d33d418dcdcfcc6ad3ab774d9cabbf7af659c/Cakefile:382:4)
  at Module._compile (node:internal/modules/cjs/loader:1120:14)
  at Object.exports.run (/builddir/build/BUILD/coffeescript-f26d33d418dcdcfcc6ad3ab774d9cabbf7af659c/lib/coffee-script/coffee-script.js:134:23)
  at Object.exports.run (/builddir/build/BUILD/coffeescript-f26d33d418dcdcfcc6ad3ab774d9cabbf7af659c/lib/coffee-script/cake.js:53:18)
  at Object.<anonymous> (/builddir/build/BUILD/coffeescript-f26d33d418dcdcfcc6ad3ab774d9cabbf7af659c/bin/cake:7:38)
  at Module._compile (node:internal/modules/cjs/loader:1120:14)
  at Object.Module._extensions..js (node:internal/modules/cjs/loader:1174:10)
  at Module.load (node:internal/modules/cjs/loader:998:32)
  at Function.Module._load (node:internal/modules/cjs/loader:839:12)
  at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12)
  at node:internal/main/run_main_module:17:47
] {
  code: 'MODULE_NOT_FOUND',
  path: '/builddir/build/BUILD/coffeescript-f26d33d418dcdcfcc6ad3ab774d9cabbf7af659c/node_modules/underscore/package.json'
}
Node.js v18.7.0
~~~

And as far as I can tell, the `underscore-node.cjs` really is not part of the nodejs-underscore package. So should it be included?



Version-Release number of selected component (if applicable):
nodejs-underscore-1.13.1-3.fc37.noarch


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:
coffee-script build is broken by nodejs-underscore.


Expected results:
coffee-script is not broken


Additional info:
The reason behind is very likely this [1] PR, but I have zero knowledge about CJS / ESM and JavaScript.


[1] https://github.com/jashkenas/underscore/pull/2914

Comment 1 Mamoru TASAKA 2023-01-13 05:24:49 UTC
I have zero knowledge anout JavaSript either, however

* looking at package.json: https://github.com/jashkenas/underscore/blob/943977e34e2279503528a71ddcc2dd5f96483945/package.json
* checking packaging on other distribution such as debian, Suse

I believe that underscore-node.cjs or so should be installed altogether.
Since installing additional scripts actually cures coffee-script build, for now I am going to modify nodejs-underscore to
package additional scripts which I seem are supposed to be installed.

Comment 2 Fedora Update System 2023-01-13 05:59:03 UTC
FEDORA-2023-d1069dfb73 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-d1069dfb73

Comment 3 Fedora Update System 2023-01-13 06:01:41 UTC
FEDORA-2023-d1069dfb73 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 4 Vít Ondruch 2023-01-13 09:22:13 UTC
Thx a lot for the fix!