Bug 2123772
| Summary: | Bundle libffi to unblock enablement of "static trampolines" | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Vít Ondruch <vondruch> |
| Component: | ghc8.10 | Assignee: | Jens Petersen <petersen> |
| Status: | CLOSED RAWHIDE | QA Contact: | |
| Severity: | unspecified | Docs Contact: | |
| Priority: | medium | ||
| Version: | 38 | CC: | codonell, petersen |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | ghc8.10-8.10.7-10.fc38 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2023-07-04 09:06:20 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 2174157 | ||
| Bug Blocks: | 2040380 | ||
|
Description
Vít Ondruch
2022-09-02 15:04:23 UTC
Sorry, only just saw this ;-( Okay I will start to move forward with switching ghc 8.10 to bundle libffi in Rawhide. I think I need to request a bundling exception to avoid getting into trouble.. See also bug 2080355, where this was planned (for F38). Thanks too for sketching the changes. (In fact I already tried this once before in May for ghc9.4, but that time I hadn't filtered out the libffi.so provides and broke the buildroot - anyway I think this can be done properly this time.) (In reply to Jens Petersen from comment #1) > I think I need to request a bundling exception to avoid getting into > trouble.. I don't think there is needed anything like this these days [1]. But of course this should not be taken lightly (which is not I guess 😉) and the `bundled()` provide is still must. And thank you for looking into this. [1]: https://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling BTW mentioning bug 2080355, should this ticket block it? (In reply to Vít Ondruch from comment #5) > BTW mentioning bug 2080355, should this ticket block it? I am not sure - actually ghc9 supports static trampolines, so libffi bundling should only be necessary for ghc8 Bundling libffi in the current ghc8.10 has turned out to be a bit harder than I foresaw. I think so further packaging changes are needed to accomplish that. Okay I have managed to do this locally for ghc8.10. I am not quite ready to push it yet, but I expect it to get into F38. They should be done in ghc8.10-8.10.7-10.fc38 now in f38-build-side-62436 This bug appears to have been reported against 'rawhide' during the Fedora Linux 38 development cycle. Changing version to 38. (In reply to Jens Petersen from comment #9) > They should be done in ghc8.10-8.10.7-10.fc38 now in f38-build-side-62436 Thank you very much for fixing this in ghc8.10! I do note that ghc8.10 accidentally exported all the bundled libffi provides e.g. https://koji.fedoraproject.org/koji/rpminfo?rpmID=33414148 ~~~ libffi.so.7()(64bit) libffi.so.7(LIBFFI_BASE_7.0)(64bit) libffi.so.7(LIBFFI_BASE_7.1)(64bit) libffi.so.7(LIBFFI_CLOSURE_7.0)(64bit) libffi.so.7(LIBFFI_COMPLEX_7.0)(64bit) libffi.so.7(LIBFFI_GO_CLOSURE_7.0)(64bit) ~~~ These should be filtered out. I've filed this bug for the filtering: https://bugzilla.redhat.com/show_bug.cgi?id=2174157 Thanks (Just noting for completeness that I noticed currently the old ghc:8.10 module only still exists in F38+ though it is okay to break that from my point of view - it could/should also be retired anyway probably) It is now possible to rebuild ghc8.10 in mock (probably for a while). https://koji.fedoraproject.org/koji/taskinfo?taskID=102905839 (x86_64 perf build) (I thought I had linked to the mock issue here but seems not, but anyway the fixed mock that allows building ghc8.10 with systemd-nspawn is already in the koji builder for some weeks/months now I think.) |