Bug 2125232

Summary: [dnf5] Update dnf5/dnf5daemon-server/dbus/interfaces/*.xml files
Product: [Fedora] Fedora Reporter: Milan Crha <mcrha>
Component: libdnfAssignee: rpm-software-management
Status: CLOSED CURRENTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: medium    
Version: 38CC: daniel.mach, jmracek, jrohel, mblaha, nsella, pkratoch, rpm-software-management
Target Milestone: ---Keywords: Triaged
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: dnf5-5.1.0 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-07-25 10:41:43 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 2124994    
Bug Blocks:    

Description Milan Crha 2022-09-08 12:04:37 UTC 
The files in dnf5/dnf5daemon-server/dbus/interfaces/*.xml do not match reality, at least the signals are wrong with what is sent to the client:

11:59:35:690 GLib-GIO Dropping signal transaction_verify_start of type (st) since the type from the expected interface is (t)
11:59:35:690 GLib-GIO Dropping signal transaction_verify_progress of type (stt) since the type from the expected interface is (tt)
11:59:35:694 GLib-GIO Dropping signal transaction_verify_progress of type (stt) since the type from the expected interface is (tt)
11:59:35:695 GLib-GIO Dropping signal transaction_verify_stop of type (st) since the type from the expected interface is (t)
11:59:36:205 GLib-GIO Dropping signal transaction_action_start of type (ssit) since the type from the expected interface is (sut)
11:59:36:205 GLib-GIO Dropping signal transaction_action_progress of type (sstt) since the type from the expected interface is (stt)
11:59:36:241 GLib-GIO Dropping signal transaction_action_stop of type (sst) since the type from the expected interface is (st)
11:59:39:169 GLib-GIO Dropping signal transaction_script_start of type (ssi) since the type from the expected interface is (s)
11:59:39:362 GLib-GIO Dropping signal transaction_script_stop of type (ssit) since the type from the expected interface is (st)

You also send a lot more signals (for example the one for package download is missing in the .xml file), I noticed that with a dbus-monitor, but as I asked for an overall progress in bug #2124994 it can be dealt with there.
Comment 1 Milan Crha 2022-09-08 12:07:29 UTC 
I forgot to mention, I'm at commit 1cfdcf554bd73ffa635915079f06bcee0b8c193e of the `dnf5` project.
Comment 2 Ben Cotton 2023-02-07 15:08:59 UTC 
This bug appears to have been reported against 'rawhide' during the Fedora Linux 38 development cycle.
Changing version to 38.
Comment 3 Milan Crha 2023-07-25 10:41:43 UTC 
Trying with 5.1.0 it seems the .xml files had been updated (or the code under the hood), because I do not see any such runtime warning any more, thus I'm closing this for now.