Bug 2125311
| Summary: | rsync-daemon fail on 3.1.3 | |||
|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 8 | Reporter: | cstackpole | |
| Component: | rsync | Assignee: | Michal Ruprich <mruprich> | |
| Status: | CLOSED ERRATA | QA Contact: | Ondrej Mejzlik <omejzlik> | |
| Severity: | medium | Docs Contact: | ||
| Priority: | urgent | |||
| Version: | 8.6 | CC: | bugproxy, fkrska, mruprich, neil, omejzlik, pasik | |
| Target Milestone: | rc | Keywords: | Reproducer, Triaged, ZStream | |
| Target Release: | --- | |||
| Hardware: | x86_64 | |||
| OS: | Linux | |||
| Whiteboard: | ||||
| Fixed In Version: | rsync-3.1.3-19.el8_7.1 | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | ||
| Clone Of: | ||||
| : | 2139118 2139119 (view as bug list) | Environment: | ||
| Last Closed: | 2023-01-26 09:20:15 UTC | Type: | Bug | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | --- | Target Upstream Version: | ||
| Embargoed: | ||||
| Bug Depends On: | ||||
| Bug Blocks: | 2139118, 2139119 | |||
|
Description
cstackpole
2022-09-08 15:10:44 UTC
Seems this might be the upstream for the breaking patch (simply trying to add relevant information): https://github.com/WayneD/rsync/issues/208 Hi, thanks for the bug report. This is most probably a result of a fix for a recent CVE. Can you please try to run you command with --old-args option? It should be a workaround for these issues. Thanks and regards, Michal Greetings, Adding `--old-args` after the `-a` flag did not make a difference. Thanks! Thanks, can you please try this test package please: https://people.redhat.com/mruprich/rsync-3.1.3-14.el8_6.4.x86_64.rpm https://people.redhat.com/mruprich/rsync-daemon-3.1.3-14.el8_6.4.noarch.rpm These contain some possible fixes from the Upstream. Thanks, Michal Sorry. No go. Same error. I updated both server and client. Thanks! Hi, sorry for longer absence here, can you please try this update? This helped me in RHEL7 with the same issue: https://people.redhat.com/mruprich/rsync-daemon-3.1.3-14.el8_6.5.noarch.rpm https://people.redhat.com/mruprich/rsync-3.1.3-14.el8_6.5.x86_64.rpm Thanks, Michal Thank you for the update. Unfortunately, exact same error. I updated both server and client. I meant to post this as verification. $ rpm -q rsync rsync-3.1.3-14.el8_6.5.x86_64 Thanks, I was finally able to reproduce this and it works fine on 3.2.7 version that is currently being released in Fedora. So there is a fix I just need to find it. Thanks for testing, I am going to come up with fix soon. Hi, I am sorry to bother you with testing, I just want to make sure this works. I was finally able to find what was wrong with the filtering and that it only occurred in the 3.1.3 version of rsync. The -x filter was not properly added as seen with --debug=all4: ... [client] add_rule(- user.*) ... This is wrong and should be like this: ... [client] add_rule(-x user.*) ... I found a path upstream that fixes this(at least for my reproducer with -x user.* but it should work for your usecase as well). So hopefully for the last time, I would like to ask you to test this package: https://people.redhat.com/mruprich/rsync-3.1.3-14.el8_6.6.x86_64.rpm https://people.redhat.com/mruprich/rsync-daemon-3.1.3-14.el8_6.6.noarch.rpm Thank you, Michal Huzzah! It works! Thank you so much for all your time and effort getting this fixed. It helps me out quite a bit. I really appreciate your help Michal! I will keep an eye out for the 3.1.3-14.el8_6.6 release. Thanks! Greetings, We got bit by this again... worse, the migration had already occurred to 8.7 so it made it even more challenging to revert back. Fortunately, I knew where to get the 3.1.3-14.el8_6.2 rpms. Just to see if things were moving along but hadn't landed in RH yet, I pulled rsync-3.1.3-19.el8.1.x86_64 from CentOS 8 Stream. Still same error as before. Which is a shame because I see that it updated earlier this month: http://mirror.centos.org/centos/8-stream/BaseOS/x86_64/os/Packages/ Any update on when we can get this fix pushed through please? Thank you! DAH! I forgot to update the client when I was testing the stream version... I take that back... rsync-3.1.3-19.el8.1.x86_64 DOES work! Huzzah! Any idea when that might land in RHEL 8.7? Thank you so much! Greetings @mruprich , It's been a month since you pushed this patch release in Stream: https://gitlab.com/redhat/centos-stream/rpms/rsync/-/commit/e5461b77ec2fdf84da618afdb9d75ab13af4fa24 Any update on when I can get this on my RHEL 8.7 systems? Thank you! It should be out within a week or so. *** Bug 2153814 has been marked as a duplicate of this bug. *** This bug should now be fixed by rsync-3.1.3-19.el8_7.1 and rsync-3.1.3-14.el8_6.4. Both of these erratas are shipped. I am closing this issue, feel free to reopen should the problem re-appear. Thanks @mruprich ! We've been testing rsync-3.1.3-19.el8_7.1 this week and things are looking good. Haven't found an issue yet. Thanks for all your help on this! It's much appreciated! Thank you for the patience, this was a weird one to solve. Hopefully this was the last time we saw this error. Regards, Michal |