Bug 2126611

Summary: Director doesn't apply OctaviaAdminLogTargets and OctaviaTenantLogTargets correctly
Product: Red Hat OpenStack Reporter: Gregory Thiemonge <gthiemon>
Component: tripleo-ansibleAssignee: Gregory Thiemonge <gthiemon>
Status: CLOSED ERRATA QA Contact: Bruna Bonguardo <bbonguar>
Severity: medium Docs Contact:
Priority: medium    
Version: 16.2 (Train)CC: chrisbro, ihrachys, lpeer, majopela, scohen, truch
Target Milestone: z5Keywords: Triaged
Target Release: 16.2 (Train on RHEL 8.4)   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: tripleo-ansible-0.8.1-2.20230131004926.b14f4bb.el8ost openstack-tripleo-heat-templates-11.6.1-2.20230201074932.89839cf.el8ost Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-04-26 12:16:45 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Gregory Thiemonge 2022-09-14 06:29:25 UTC 
Description of problem:
A user might override the default endpoints for rsyslog servers using the OctaviaAdminLogTargets and OctaviaTenantLogTargets parameters from THT
But setting those options doesn't work properly, the default endpoints are still defined in the octavia configuration file

Version-Release number of selected component (if applicable):
16.2 (16.1 and 17.0 too)

How reproducible:
100%

Steps to Reproduce:
1. Deploy OSP with Octavia, define OctaviaAdminLogTargets
2. Check the DEBUG output of the Octavia services, amphora_agent.admin_log_targets is not set correctly
3.


I used the following parameters:

parameter_defaults:
  OctaviaAdminLogTargets: 172.17.0.2:514
  OctaviaTenantLogTargets: 172.17.0.3:514

after deployment in worker.log:
2022-09-13 14:05:57.134 24 DEBUG cotyledon.oslo_config_glue [-] amphora_agent.admin_log_targets = ['172.24.1.180:514', '172.24.1.117:514', '172.24.1.107:514'] log_opt_values /usr/lib/python3.6/site-packages/oslo_config/cfg.py:2589

This is the default parameter (the 3 controllers)

[root@controller-0 heat-admin]# grep admin_log_targets -r /var/lib/config-data/puppet-generated/octavia -r
/var/lib/config-data/puppet-generated/octavia/etc/octavia/octavia.conf:# admin_log_targets =
/var/lib/config-data/puppet-generated/octavia/etc/octavia/octavia.conf:admin_log_targets=172.17.0.2:514
/var/lib/config-data/puppet-generated/octavia/etc/octavia/post-deploy.conf:admin_log_targets = 172.24.1.180:514, 172.24.1.117:514, 172.24.1.107:514

puppet-octavia sets the right value in octavia.conf
but tripleo-ansible overrides the parameter with computed values (IPs of the controllers + :514)
Comment 3 Gregory Thiemonge 2022-09-15 14:14:30 UTC 
Update on the fix:

OctaviaAdminLogTargets and OctaviaTenantLogTargets no longer affects the octavia settings (octavia.conf), they only affect the configuration of the octavia-rsyslog container, creating an rsyslog forwarder when one of these params is set.
Comment 12 errata-xmlrpc 2023-04-26 12:16:45 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Red Hat OpenStack Platform 16.2.5 (Train) bug fix and enhancement advisory), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2023:1763