Bug 2126808

Summary:	Adding cockpit origin without cockpit enabled succeeds
Product:	Red Hat Satellite	Reporter:	Peter Dragun <pdragun>
Component:	Installer	Assignee:	satellite6-bugs <satellite6-bugs>
Status:	CLOSED NOTABUG	QA Contact:	Gaurav Talreja <gtalreja>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	6.12.0	CC:	ehelms
Target Milestone:	Unspecified	Keywords:	Triaged
Target Release:	Unused
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-09-24 17:41:04 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Peter Dragun 2022-09-14 13:01:45 UTC

Description of problem:
Adding cockpit origin using installer when the cockpit is not installed and enabled does not result in any error or warning during installation.

Version-Release number of selected component (if applicable):


How reproducible:
always

Steps to Reproduce:
1. Run e.g.: satellite-installer --foreman-plugin-remote-execution-cockpit-origins http://www.example.com
2. Wait for the job to complete.
3. See the result

Actual results:
Success

Expected results:
The installer should add some warning that the cockpit is not installed

Additional info:

Comment 1 Brad Buckingham 2022-09-15 14:15:49 UTC

Is this a regression in behavior from Satellite 6.11?

Thanks!

Comment 2 Peter Dragun 2022-09-16 08:08:27 UTC

No, this option is new in 6.12

Comment 3 Eric Helms 2022-09-24 17:41:04 UTC

This behavior is true of any option passed to the installer for a feature that is not enabled. User's must have previously enabled cockpit support or enable it as part of the same command:

    --[no-]enable-foreman-plugin-remote-execution-cockpit Enable 'foreman_plugin_remote_execution_cockpit' puppet module (default: false)