Bug 2127627
| Summary: | Review Request: php-splitbrain-php-archive - pure-PHP handling of zip and tar archives | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Artur Frenszek-Iwicki <fedora> | ||||||
| Component: | Package Review | Assignee: | Remi Collet <fedora> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | medium | ||||||||
| Version: | rawhide | CC: | fedora, package-review | ||||||
| Target Milestone: | --- | Flags: | fedora:
fedora-review+
|
||||||
| Target Release: | --- | ||||||||
| Hardware: | All | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2022-11-10 22:15:22 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
|
Description
Artur Frenszek-Iwicki
2022-09-17 15:17:45 UTC
Created attachment 1913068 [details]
phpci.log
Created attachment 1913069 [details]
review.txt
[~]: Requires correct, justified where necessary. From phpcompatinfo report, this library use date, hash and pcre ext. Despite there are always there, Guidelines say they must be required => https://fedoraproject.org/wiki/Packaging:PHP#Extensions_Requires Also: Requires: php(language) >= 7.0 Package use /usr/share/php/splitbrain-php-archive Not part of the Guidelines but common usage is /usr/share/php/splitbrain/php-archive (using composer name) or /usr/share/php/splitbrain/PHPArchive (using namespace, so PSR0 compatible) Notice: if you plan to build for EPEL, you should make test suite conditional (as EPEL don't have any PHPUnit versions) > Created attachment 1913068 [details] > phpci.log What's the program used for generating this report? > Not part of the Guidelines but common usage is > /usr/share/php/splitbrain/php-archive (using composer name) > or > /usr/share/php/splitbrain/PHPArchive (using namespace, so PSR0 compatible) Hm, the PHP packages I submitted previously all used the "composerVendor-composerName" format, but I guess the namespace/PSR0 scheme makes more sense. > Notice: if you plan to build for EPEL, you should > make test suite conditional (as EPEL don't have any PHPUnit versions) Not planning EPEL builds currently. All the php-splibrain-* packages I've submitted for review are dependencies of dokuwiki, currently bundled with that package. (In reply to Artur Frenszek-Iwicki from comment #4) > > Created attachment 1913068 [details] > > phpci.log > What's the program used for generating this report? the phpcompatinfo command provided by the php-bartlett-PHP-CompatInfo package automatically run by fedora-review when installed. Notice: only missing dep. is a blocker others comment are your choice Added the missing deps and changed the directory structure. spec: https://svgames.pl/fedora/php-splitbrain-php-archive-1.3.1-2/php-splitbrain-php-archive.spec srpm: https://svgames.pl/fedora/php-splitbrain-php-archive-1.3.1-2/php-splitbrain-php-archive-1.3.1-2.fc37.src.rpm koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=92405289 Dependencies fixed. ==== APPROVED ==== (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/php-splitbrain-php-archive FEDORA-2022-71439731b0 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-71439731b0 FEDORA-2022-71439731b0 has been pushed to the Fedora 37 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-71439731b0 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-71439731b0 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2022-71439731b0 has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report. |