Bug 2127628

Summary: Review Request: php-splitbrain-php-cli - PHP library for building command-line tools
Product: [Fedora] Fedora Reporter: Artur Frenszek-Iwicki <fedora>
Component: Package ReviewAssignee: Remi Collet <fedora>
Status: CLOSED ERRATA QA Contact: Remi Collet <fedora>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora, package-review
Target Milestone: ---Flags: fedora: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-11-10 22:15:24 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
review.txt
none
phpci.log none

Description Artur Frenszek-Iwicki 2022-09-17 15:19:52 UTC 
spec: https://svgames.pl/fedora/php-splitbrain-php-cli-1.2.0-1/php-splitbrain-php-cli.spec
srpm: https://svgames.pl/fedora/php-splitbrain-php-cli-1.2.0-1/php-splitbrain-php-cli-1.2.0-1.fc36.src.rpm
koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=92116142

Description: PHP-CLI is a simple library that helps with creating command line scripts. It takes care of option parsing, help page generation, automatic width adjustment and coloured output.

Fedora Account System Username: suve
Comment 1 Artur Frenszek-Iwicki 2022-09-28 21:40:27 UTC 
Added missing deps and made the directory hierarchy PSR-0 compliant.

spec: https://svgames.pl/fedora/php-splitbrain-php-cli-1.2.0-2/php-splitbrain-php-cli.spec
srpm: https://svgames.pl/fedora/php-splitbrain-php-cli-1.2.0-2/php-splitbrain-php-cli-1.2.0-2.fc37.src.rpm
koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=92405294
Comment 2 Remi Collet 2022-09-29 14:10:58 UTC 
Created attachment 1915038 [details]
review.txt
Comment 3 Remi Collet 2022-09-29 14:11:19 UTC 
Created attachment 1915039 [details]
phpci.log
Comment 4 Remi Collet 2022-09-29 14:13:03 UTC 
[x]: Package complies to the Packaging Guidelines


==== APPROVED ====



Notice: you may prefer to use modern bcond instead of "with_tests" macro

%bcond_without tests

and 

%if %{with tests}

(as both rpmbuild and mock support the --with / --without options)
Comment 5 Gwyn Ciesla 2022-10-03 15:15:54 UTC 
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/php-splitbrain-php-cli
Comment 6 Fedora Update System 2022-10-11 16:10:55 UTC 
FEDORA-2022-71439731b0 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-71439731b0
Comment 7 Fedora Update System 2022-10-12 09:38:22 UTC 
FEDORA-2022-71439731b0 has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-71439731b0 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-71439731b0

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
Comment 8 Fedora Update System 2022-11-10 22:15:24 UTC 
FEDORA-2022-71439731b0 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.