Bug 2127629

Summary: Review Request: php-splitbrain-slika - image handling library for PHP
Product: [Fedora] Fedora Reporter: Artur Frenszek-Iwicki <fedora>
Component: Package ReviewAssignee: Remi Collet <fedora>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora, package-review
Target Milestone: ---Flags: fedora: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-11-10 22:15:26 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
review.txt
none
phpci.log none

Description Artur Frenszek-Iwicki 2022-09-17 15:28:40 UTC 
spec: https://svgames.pl/fedora/php-splitbrain-slika-1.0.5-1/php-splitbrain-slika.spec
srpm: https://svgames.pl/fedora/php-splitbrain-slika-1.0.5-1/php-splitbrain-slika-1.0.5-1.fc36.src.rpm
koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=92116404

Description: Slika is a simple image handling library for PHP, covering the bare basics: resizing, cropping, rotation. It can use either PHP's GD extension or an ImageMagick binary.

Fedora Account System Username: suve
Comment 1 Artur Frenszek-Iwicki 2022-09-28 21:41:21 UTC 
Added missing deps and made the directory hierarchy PSR-0 compliant.

spec: https://svgames.pl/fedora/php-splitbrain-slika-1.0.5-2/php-splitbrain-slika.spec
srpm: https://svgames.pl/fedora/php-splitbrain-slika-1.0.5-2/php-splitbrain-slika-1.0.5-2.fc37.src.rpm
koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=92405308
Comment 2 Remi Collet 2022-09-29 14:30:53 UTC 
Created attachment 1915041 [details]
review.txt
Comment 3 Remi Collet 2022-09-29 14:31:33 UTC 
Created attachment 1915042 [details]
phpci.log
Comment 4 Remi Collet 2022-09-29 14:34:48 UTC 
[!]: Requires correct, justified where necessary.

Package cannot be installed because of bad dependencies

Requires: (ImageMagick) or (php-gd)

This should be (bracket removed)

Requires: (php-gd or ImageMagick)

(php-gd as first, so preferred, but your choice)
Comment 5 Artur Frenszek-Iwicki 2022-10-06 22:11:28 UTC 
Fixed the Requires: issue.

spec: https://svgames.pl/fedora/php-splitbrain-slika-1.0.5-3/php-splitbrain-slika.spec
srpm: https://svgames.pl/fedora/php-splitbrain-slika-1.0.5-3/php-splitbrain-slika-1.0.5-3.fc37.src.rpm
koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=92715462
Comment 6 Remi Collet 2022-10-07 13:46:53 UTC 
[x]: Requires correct, justified where necessary.


Notice: test suite passes with PHP 8.0, 8.1 and 8.2

==== APPROVED ====
Comment 7 Gwyn Ciesla 2022-10-10 13:37:53 UTC 
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/php-splitbrain-slika
Comment 8 Fedora Update System 2022-10-11 16:10:58 UTC 
FEDORA-2022-71439731b0 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-71439731b0
Comment 9 Fedora Update System 2022-10-12 09:38:24 UTC 
FEDORA-2022-71439731b0 has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-71439731b0 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-71439731b0

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
Comment 10 Fedora Update System 2022-11-10 22:15:26 UTC 
FEDORA-2022-71439731b0 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.