Bug 2128030
| Summary: | RFE: Add support for NVMeoF initiator | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 9 | Reporter: | Tomáš Bžatek <tbzatek> |
| Component: | pykickstart | Assignee: | Brian Lane <bcl> |
| Status: | CLOSED MIGRATED | QA Contact: | Release Test Team <release-test-team-automation> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 9.2 | CC: | jkonecny, vtrefny |
| Target Milestone: | rc | Keywords: | FutureFeature, MigratedToJIRA |
| Target Release: | --- | Flags: | pm-rhel:
mirror+
|
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2023-09-18 16:00:36 UTC | Type: | Story |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Tomáš Bžatek
2022-09-19 16:34:31 UTC
Changes like this need to be done upstream first, and Anaconda will require most of the work for this. Please file an RFE with Anaconda as well. Also, I'm increasingly reluctant to add so many arguments to commands, linking in every last option from the underlying tools makes things harder to use. Where possible we should use some kind of option passthru for things like timeouts, delays, etc. (In reply to Brian Lane from comment #2) > Where possible we should use some kind of option passthru for things like timeouts, delays, etc. Ah, right, good idea! In fact, the lower layers (libblockdev) already work this way: http://storaged.org/libblockdev/3.0/libblockdev-NVMe.html#bd-nvme-connect So this kickstart support would only be a pass-through to blivet which itself will work as a pass-through to down to libblockdev. Also, the NVMe standard is ever evolving and we'll be gradually adding new options as new standard additions emerge. In that case, I think we could strip down the kickstart command to the following primary options: > nvme --subsysnqn SUBSYSNQN --transport TRANSPORT [--transport_addr ADDRESS] [--iface IFACE] [extra_options...] and the rest of the options would just be a pass through further down. We can copy&paste the optional arguments from blivet/libblockdev, to have them documented. (technically it would be nice to have some checks here, e.g. that the IFACE specified is present and up or that the ADDRESS passes syntax check for the given TRANSPORT family (e.g. ipv4/ipv6 address validation or DNS resolve test)..) (In reply to Tomáš Bžatek from comment #4) > > (technically it would be nice to have some checks here, e.g. that the IFACE > specified is present and up or that the ADDRESS passes syntax check for the > given TRANSPORT family (e.g. ipv4/ipv6 address validation or DNS resolve > test)..) That would be handled by Anaconda, and is probably a good dividing line for what to pass via --extra and what to make a specific argument. eg. Assume no checking until the bottom layer for --extra options, and some level of checking for named arguments like IFACE. Issue migration from Bugzilla to Jira is in process at this time. This will be the last message in Jira copied from the Bugzilla bug. This BZ has been automatically migrated to the issues.redhat.com Red Hat Issue Tracker. All future work related to this report will be managed there. Due to differences in account names between systems, some fields were not replicated. Be sure to add yourself to Jira issue's "Watchers" field to continue receiving updates and add others to the "Need Info From" field to continue requesting information. To find the migrated issue, look in the "Links" section for a direct link to the new issue location. The issue key will have an icon of 2 footprints next to it, and begin with "RHEL-" followed by an integer. You can also find this issue by visiting https://issues.redhat.com/issues/?jql= and searching the "Bugzilla Bug" field for this BZ's number, e.g. a search like: "Bugzilla Bug" = 1234567 In the event you have trouble locating or viewing this issue, you can file an issue by sending mail to rh-issues. You can also visit https://access.redhat.com/articles/7032570 for general account information. |