Bug 2128864

Summary: Repo Deletion with no feed url causes a `ArgumentError`
Product: Red Hat Satellite Reporter: Samir Jha <sajha>
Component: RepositoriesAssignee: Samir Jha <sajha>
Status: CLOSED ERRATA QA Contact: Chris Roberts <chrobert>
Severity: medium Docs Contact:
Priority: medium    
Version: 6.11.0CC: chrobert, jpasqual, paji, pcreech
Target Milestone: 6.13.0Keywords: EasyFix, Triaged
Target Release: Unused   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: rubygem-katello-4.7.0 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-05-03 13:22:11 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Screenshot of repo without feed url
none
Screenshot showing repo deletion was completed none

Description Samir Jha 2022-09-21 18:14:44 UTC 
Deleting repositories that have no feed url causes the following error.
<pre>

ArgumentError
bad argument (expected URI object or URI string)
- "/usr/share/ruby/uri/common.rb:739:in `URI'"
- "/home/vagrant/katello/app/services/katello/pulp3/repository/yum.rb:15:in `remote_options'"
- "/home/vagrant/katello/app/services/katello/pulp3/repository.rb:102:in `block in
  delete_remote'"
- "/home/vagrant/katello/app/services/katello/pulp3/service_common.rb:51:in `ignore_404_exception'"
- "/home/vagrant/katello/app/services/katello/pulp3/repository.rb:102:in `delete_remote'"
- "/home/vagrant/katello/app/lib/actions/pulp3/repository/delete_remote.rb:11:in `invoke_external_task'"
</pre>

Steps to repro
* Create a custom repo with feed url
* Now remove feed url and update the repo
* Delete the repo

Expected:
Successful deletion

Actual:
Above error


Additional Notes:
When a repo has a feed url a repo remote is created in pulp. Possibly on repo update the remotes are not getting cleaned properly.
Comment 1 Samir Jha 2022-09-21 18:14:48 UTC 
Created from redmine issue https://projects.theforeman.org/issues/35534
Comment 2 Samir Jha 2022-09-21 18:14:50 UTC 
Upstream bug assigned to None
Comment 3 Bryan Kearney 2022-09-22 20:04:32 UTC 
Moving this bug to POST for triage into Satellite since the upstream issue https://projects.theforeman.org/issues/35534 has been resolved.
Comment 5 Chris Roberts 2023-01-05 18:41:09 UTC 
Created attachment 1936027 [details]
Screenshot of repo without feed url
Comment 6 Chris Roberts 2023-01-05 18:41:47 UTC 
Created attachment 1936028 [details]
Screenshot showing repo deletion was completed
Comment 7 Chris Roberts 2023-01-05 18:43:31 UTC 
Tested the following:

Created a repo with a url to https://fixtures.pulpproject.org/rpm-unsigned/

Removed the url and updated the repo - See screenshot

Deleted the repo and it completed ok - See screenshot

moving to VERIFIED
Comment 10 errata-xmlrpc 2023-05-03 13:22:11 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: Satellite 6.13 Release), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2023:2097
Comment 11 Lucy Fu 2023-07-03 20:41:59 UTC 
*** Bug 2164238 has been marked as a duplicate of this bug. ***