Bug 2129503

Summary:	Review Request: rubygem-net-ssh-gateway - A simple library to assist in establishing tunneled Net::SSH connections
Product:	[Fedora] Fedora	Reporter:	Robby Callicotte <rcallicotte>
Component:	Package Review	Assignee:	Benson Muite <benson_muite>
Status:	CLOSED NOTABUG	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	benson_muite, package-review
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-12-24 00:45:28 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	201449

Description Robby Callicotte 2022-09-24 06:11:19 UTC

Spec URL: https://rcallicotte.fedorapeople.org/rubygem-net-ssh-gateway.spec
SRPM URL: https://rcallicotte.fedorapeople.org/rubygem-net-ssh-gateway-2.0.0-2.fc38.src.rpm
Description: A simple library to assist in establishing tunneled Net::SSH connections
Fedora Account System Username: rcallicotte

Comment 1 Robby Callicotte 2022-09-24 06:15:40 UTC

Releng ticket for unretiring package:
https://pagure.io/releng/issue/11045

Comment 2 Benson Muite 2022-11-21 06:08:24 UTC

remove %{gem_instdir}/Rakefile from the spec file

fedora-review fails. Build log output:

~/build/BUILD/net-ssh-gateway-2.0.0/usr/share/gems/gems/net-ssh-gateway-2.0.0 ~/build/BUILD/net-ssh-gateway-2.0.0
+ ln -s /builddir/build/BUILD/test .
+ sed -i '/bundler/ s/^/#/' test/net/ssh/gateway_test.rb
+ ruby -Ilib -e 'Dir.glob "./test/**/*_test.rb", &method(:require)'
<internal:/usr/share/rubygems/rubygems/core_ext/kernel_require.rb>:85:in `require': cannot load such file -- mocha/mini_test (LoadError)
	from <internal:/usr/share/rubygems/rubygems/core_ext/kernel_require.rb>:85:in `require'
	from /builddir/build/BUILD/net-ssh-gateway-2.0.0/usr/share/gems/gems/net-ssh-gateway-2.0.0/test/net/ssh/gateway_test.rb:4:in `<top (required)>'
	from <internal:/usr/share/rubygems/rubygems/core_ext/kernel_require.rb>:85:in `require'
	from <internal:/usr/share/rubygems/rubygems/core_ext/kernel_require.rb>:85:in `require'
	from <internal:dir>:220:in `glob'
	from -e:1:in `<main>'
error: Bad exit status from /var/tmp/rpm-tmp.VW0zkn (%check)
RPM build errors:
    Bad exit status from /var/tmp/rpm-tmp.VW0zkn (%check)
Child return code was: 1

Comment 3 Package Review 2023-11-22 00:45:30 UTC

This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time, but it seems
that the review is still being working out by you. If this is right, please
respond to this comment clearing the NEEDINFO flag and try to reach out the
submitter to proceed with the review.

If you're not interested in reviewing this ticket anymore, please clear the
fedora-review flag and reset the assignee, so that a new reviewer can take
this ticket.

Without any reply, this request will shortly be resetted.

Comment 4 Package Review 2023-12-24 00:45:28 UTC

This is an automatic action taken by review-stats script.

The ticket submitter failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we consider this ticket as DEADREVIEW and proceed to close it.