Bug 2129837
| Summary: | Review Request: perl-Alien-Build-Plugin-Download-GitLab - Alien::Build plugin to download from GitLab | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jitka Plesnikova <jplesnik> |
| Component: | Package Review | Assignee: | Petr Pisar <ppisar> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, ppisar |
| Target Milestone: | --- | Flags: | ppisar:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | perl-Alien-Build-Plugin-Download-GitLab-0.01-1.fc38 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2022-10-03 09:48:08 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2129628 | ||
|
Description
Jitka Plesnikova
2022-09-26 12:10:31 UTC
URL and Source0 addresses are usable. Ok.
TODO: Remove a trailing slash from URL tag value.
Source archive (SHA-512: 5a1a1dcefbec09732e377c47a961d57cc21a54fef154158dbad1738a93a143348ddc69430b35207d9db111a74592a7120b2abf2f7045818a74a6397bbf07fb06) is original. Ok.
Summary verified from lib/Alien/Build/Plugin/Download/GitLab.pm. Ok.
Description verified from lib/Alien/Build/Plugin/Download/GitLab.pm. Ok.
License verified from lib/Alien/Build/Plugin/Download/GitLab.pm, dist.ini, README, LICENSE. Ok.
No XS code, noarch BuildArch is Ok.
Build-requires are Ok.
All tests pass. Ok.
$ rpmlint perl-Alien-Build-Plugin-Download-GitLab.spec ../SRPMS/perl-Alien-Build-Plugin-Download-GitLab-0.01-1.fc38.src.rpm ../RPMS/noarch/perl-Alien-Build-Plugin-Download-GitLab-0.01-1.fc38.noarch.rpm
======================================== rpmlint session starts =======================================
rpmlint: 2.2.0
configuration:
/usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
/etc/xdg/rpmlint/fedora-legacy-licenses.toml
/etc/xdg/rpmlint/fedora-spdx-licenses.toml
/etc/xdg/rpmlint/fedora.toml
/etc/xdg/rpmlint/licenses.toml
/etc/xdg/rpmlint/scoring.toml
/etc/xdg/rpmlint/users-groups.toml
/etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 3
========= 2 packages and 1 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.2 s ========
rpmlint is Ok.
$ rpm -q -lv -p ../RPMS/noarch/perl-Alien-Build-Plugin-Download-GitLab-0.01-1.fc38.noarch.rpm
drwxr-xr-x 2 root root 0 Sep 29 18:16 /usr/share/doc/perl-Alien-Build-Plugin-Download-GitLab
-rw-r--r-- 1 root root 115 Sep 24 00:11 /usr/share/doc/perl-Alien-Build-Plugin-Download-GitLab/Changes
-rw-r--r-- 1 root root 1931 Sep 24 00:11 /usr/share/doc/perl-Alien-Build-Plugin-Download-GitLab/README
drwxr-xr-x 2 root root 0 Sep 29 18:16 /usr/share/licenses/perl-Alien-Build-Plugin-Download-GitLab
-rw-r--r-- 1 root root 18344 Sep 24 00:11 /usr/share/licenses/perl-Alien-Build-Plugin-Download-GitLab/LICENSE
-rw-r--r-- 1 root root 2069 Sep 29 18:16 /usr/share/man/man3/Alien::Build::Plugin::Download::GitLab.3pm.gz
drwxr-xr-x 2 root root 0 Sep 29 18:16 /usr/share/perl5/vendor_perl/Alien
drwxr-xr-x 2 root root 0 Sep 29 18:16 /usr/share/perl5/vendor_perl/Alien/Build
drwxr-xr-x 2 root root 0 Sep 29 18:16 /usr/share/perl5/vendor_perl/Alien/Build/Plugin
drwxr-xr-x 2 root root 0 Sep 29 18:16 /usr/share/perl5/vendor_perl/Alien/Build/Plugin/Download
-rw-r--r-- 1 root root 5963 Sep 24 00:11 /usr/share/perl5/vendor_perl/Alien/Build/Plugin/Download/GitLab.pm
File layout and permissions are Ok.
$ rpm -q --requires -p ../RPMS/noarch/perl-Alien-Build-Plugin-Download-GitLab-0.01-1.fc38.noarch.rpm | sort -f | uniq -c
1 perl(:MODULE_COMPAT_5.36.0)
1 perl(:VERSION) >= 5.8.4
1 perl(Alien::Build::Plugin)
1 perl(Carp)
1 perl(File::Basename)
1 perl(JSON::PP)
1 perl(Path::Tiny)
1 perl(strict)
1 perl(URI)
1 perl(URI::Escape)
1 perl(warnings)
1 rpmlib(CompressedFileNames) <= 3.0.4-1
1 rpmlib(FileDigests) <= 4.6.0-1
1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
1 rpmlib(PayloadIsZstd) <= 5.4.18-1
Binary requires are Ok.
$ rpm -q --provides -p ../RPMS/noarch/perl-Alien-Build-Plugin-Download-GitLab-0.01-1.fc38.noarch.rpm | sort -f | uniq -c
1 perl(Alien::Build::Plugin::Download::GitLab) = 0.01
1 perl-Alien-Build-Plugin-Download-GitLab = 0.01-1.fc38
Binary provides are Ok.
$ resolvedeps rawhide ../RPMS/noarch/perl-Alien-Build-Plugin-Download-GitLab-0.01-1.fc38.noarch.rpm
Binary dependencies are resolvable. Ok.
The package builds in Fedora 38 (https://koji.fedoraproject.org/koji/taskinfo?taskID=92421764). Ok.
The package is in line with Fedora and Perl packaging guidelines.
Resolution: Package APPROVED.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Alien-Build-Plugin-Download-GitLab Thank you for review and repository. |