Bug 2129845

Summary:	[machines] There will be several network interfaces added if clicking the "Add" button multiple times at the same time
Product:	Red Hat Enterprise Linux 8	Reporter:	YunmingYang <yunyang>
Component:	cockpit-appstream	Assignee:	Simon Kobyda <skobyda>
Status:	CLOSED ERRATA	QA Contact:	YunmingYang <yunyang>
Severity:	low	Docs Contact:
Priority:	unspecified
Version:	8.7	CC:	mpitt, qzhang, wshi, xchen, ymao
Target Milestone:	rc	Keywords:	Triaged
Target Release:	8.8	Flags:	pm-rhel: mirror+
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	cockpit-appstream-279-1.el8	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-05-16 08:35:46 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description YunmingYang 2022-09-26 12:44:04 UTC

Description of problem:
If clicking the "Add" button of the "Add virtual network interface" dialog multiple times at the same time, there will be several network interfaces added, but it should be only one interface added.

Version-Release number of selected components (if applicable):
cockpit-machines-276-1.el8.noarch
cockpit-275-1.el8.x86_64
libvirt-dbus-1.3.0-2.module+el8.6.0+12861+13975d62.x86_64

How reproducible:
100%

Steps to Reproduce:
1 Prepare a shutoff VM, then enter the VM detail page
2 Click "Add network interface"
3 Click "Add" multiple times at the same time

Actual results:
1 There will be several network interfaces added

Expected results:
1 There should be only one network interface added

Additional info:

Comment 1 Martin Pitt 2022-09-30 04:25:48 UTC

Fixed upstream in https://github.com/cockpit-project/cockpit-machines/pull/819

Comment 3 Xianghua Chen 2022-11-17 08:06:12 UTC

As the ITM Is the deadline for verification and we still not have the build on RHEL8.8, I change the ITM 2 weeks later in case we would lose the release+.
Feel free to change it per your estimation.

Comment 6 YunmingYang 2022-11-29 10:54:05 UTC

Test Versions:
cockpit-279-1.el8.x86_64
cockpit-machines-279-1.el8.noarch
libvirt-dbus-1.3.0-2.module+el8.8.0+16781+9f4724c2.x86_64


Test Steps:
1 Prepare a shut off VM, then enter the VM detail page
2 Click "Add network interface"
3 Click "Add" multiple times at the same time


Test Results:
1 There is only one network interface added


According to the results, move status to VERIFIED.

Comment 10 errata-xmlrpc 2023-05-16 08:35:46 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (cockpit-appstream bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2023:2821