Bug 213058
Summary: | Audacious wakes up ~600 times / second | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Henning Norén <henning.noren> |
Component: | audacious | Assignee: | Ralf Ertzinger <redhat-bugzilla> |
Status: | CLOSED WONTFIX | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | 7 | CC: | extras-qa, triage |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2008-06-17 01:14:23 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 204948 |
Description
Henning Norén
2006-10-30 18:09:53 UTC
Hmmm, looks like ancient leftovers, xmms does this as well :) I'll report this to upstream, but don't hold your breath about this. Well, I got the title wrong... It's 600 syscalls / second, not wakeups (they are probably around 100/second) from the numbers above. And I noticed that turning off visualization-plugin and autoscrolling made the numbers a bit more sensible (at least removes the open/close/write and the clock_gettime). I did contact upstream but after being insulted and practically ignored by some of the developers I hardly think they will get down from their high horses and do anything about it. I'll see if I can take a look into it as soon as I get some time though... The issue is probably a timeout that needs to be set higher and using interrupt on the polling thread instead of constantly checking a variable. Ok, this one will be tricky... I found the offending code and from a quick look it will demand some rewrite to fix. The offending line is the following in main.c (in both xmms and Audacious): mainwin_timeout_tag = gtk_timeout_add(10, idle_func, NULL); Bluntly removing it makes the repainting of graphics highly defective but the player is still working and a strace shows that the continous polling when idle is gone. A quite simple fix would be to increase the first parameter from 10 to 100, and cutting the number of calls down by 10. And gtk_add_timeout is deprecated anyway, and should be replaced by g_timeout_add. I'll take a look at what that idle function is doing, anyway. Errr... I seem to be unable to find the source line you qouted in the audacious 1.1.2 source tarball. Nevermind, found it. sorry, it was in xmms... They have changed the code a bit but the new line is; mainwin.c:3362 mainwin_timeout_id = g_timeout_add(MAINWIN_UPDATE_INTERVAL, mainwin_idle_func, NULL); Where MAINWIN_UPDATE_INTERVAL is defined as 10, so it's pretty much the same. Testing a patch in devel shows that simply reducing this variable has unwanted side effects. So currently I see no simple way around this. If you are willing to work further on this you're welcome, of course. This message is a reminder that Fedora 7 is nearing the end of life. Approximately 30 (thirty) days from now Fedora will stop maintaining and issuing updates for Fedora 7. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as WONTFIX if it remains open with a Fedora 'version' of '7'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version prior to Fedora 7's end of life. Bug Reporter: Thank you for reporting this issue and we are sorry that we may not be able to fix it before Fedora 7 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora please change the 'version' of this bug. If you are unable to change the version, please add a comment here and someone will do it for you. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete. If possible, it is recommended that you try the newest available Fedora distribution to see if your bug still exists. Please read the Release Notes for the newest Fedora distribution to make sure it will meet your needs: http://docs.fedoraproject.org/release-notes/ The process we are following is described here: http://fedoraproject.org/wiki/BugZappers/HouseKeeping Fedora 7 changed to end-of-life (EOL) status on June 13, 2008. Fedora 7 is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug. If you can reproduce this bug against a currently maintained version of Fedora please feel free to reopen this bug against that version. Thank you for reporting this bug and we are sorry it could not be fixed. |