Bug 2131090

Summary: Patch3 reverts a patch merged upstream
Product: Red Hat Enterprise Linux 8 Reporter: Paulo Andrade <pandrade>
Component: iscsi-initiator-utilsAssignee: Chris Leech <cleech>
Status: VERIFIED --- QA Contact: Martin Hoyer <mhoyer>
Severity: urgent Docs Contact:
Priority: urgent    
Version: 8.5CC: cwei, jbrassow, jmagrini, jpittman, ldigby, mgandhi, mhoyer
Target Milestone: rcKeywords: Regression, Triaged, ZStream
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: iscsi-initiator-utils-6.2.1.4-8.git095f59c.el8 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 2215111 (view as bug list) Environment:
Last Closed: Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2215111    
Attachments:
Description Flags
bz2131090.patch none

Description Paulo Andrade 2022-09-29 20:34:08 UTC 
Without patches open-iscsi-095f59c.tar.gz already has the fix for
https://github.com/open-iscsi/open-iscsi/pull/244

  But 0003-idbm_rec_write-seperate-old-and-new-style-writes.patch
reverts the upstream fix.

  Basically, the chunks:

-@@ -2148,39 +2143,8 @@ static int idbm_rec_write(node_rec_t *rec, bool disable_lock)
+@@ -2170,39 +2165,8 @@ static int idbm_rec_write(node_rec_t *rec, bool disable_lock)
                return ISCSI_ERR_NOMEM;
        }
  
 -      snprintf(portal, PATH_MAX, "%s", NODE_CONFIG_DIR);
 -      if (access(portal, F_OK) != 0) {
--              if (mkdir(portal, 0660) != 0) {
+-              if (mkdir(portal, 0770) != 0) {
 -                      log_error("Could not make %s: %s", portal,
 -                                strerror(errno));
 -                      rc = ISCSI_ERR_IDBM;
@@ -42,7 +42,7 @@ index e6ede85..bc51388 100644
 -
 -      snprintf(portal, PATH_MAX, "%s/%s", NODE_CONFIG_DIR, rec->name);
 -      if (access(portal, F_OK) != 0) {
--              if (mkdir(portal, 0660) != 0) {
+-              if (mkdir(portal, 0770) != 0) {
 -                      log_error("Could not make %s: %s", portal,
 -                                strerror(errno));
 -                      rc = ISCSI_ERR_IDBM;

should have been a mistake, when updating to latest upstream release, related
to bz#1921626.
Comment 1 Paulo Andrade 2022-10-07 18:33:11 UTC 
Created attachment 1916748 [details]
bz2131090.patch

User is running a modified package, with this patch, and confirms that
it corrects the problem.