Bug 2131199

Summary:	Review Request: perl-Alien-m4 - Find GNU m4
Product:	[Fedora] Fedora	Reporter:	Petr Pisar <ppisar>
Component:	Package Review	Assignee:	Jitka Plesnikova <jplesnik>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	jplesnik, package-review
Target Milestone:	---	Flags:	jplesnik: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	perl-Alien-m4-0.21-1.fc38	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-10-07 07:32:23 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Petr Pisar 2022-09-30 08:56:03 UTC

Spec URL: https://ppisar.fedorapeople.org/perl-Alien-m4/perl-Alien-m4.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Alien-m4/perl-Alien-m4-0.21-1.fc38.src.rpm
Description: This package can be used by other Perl modules that require GNU m4.

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2022-10-06 14:15:49 UTC

Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Alien-m4-0.21-1.fc38.x86_64.rpm | sort | uniq -c | grep -v rpmlib
      1 m4 = 1.4.19
      1 perl(Alien::Base) >= 0.038
      1 perl(alienfile) >= 0.32
      1 perl(base)
      1 perl(Capture::Tiny)
      1 perl(Config)
      1 perl(:MODULE_COMPAT_5.36.0)
      1 perl(Path::Tiny)
      1 perl(strict)
      1 perl(warnings)
Binary requires are Ok.
$ rpm -qp --requires perl-Alien-m4-tests-0.21-1.fc38.noarch.rpm | sort | uniq -c | grep -v rpmlib
      1 perl(Alien::m4)
      1 perl-Alien-m4 = 0.21-1.fc38
      1 perl(Config)
      1 perl(strict)
      1 perl(Test::Alien)
      1 perl-Test-Harness
      1 perl(warnings)
      1 /usr/bin/perl
      1 /usr/bin/sh
FIX: 'perl(Test2::V0)' and 'perl(Test::More)' should be listed as
     run-requires not build-requires.

$ rpm -qp --provides perl-Alien-m4-0.21-1.fc38.x86_64.rpm | sort | uniq -c
      1 perl(Alien::m4) = 0.21
      1 perl-Alien-m4 = 0.21-1.fc38
      1 perl-Alien-m4(x86-64) = 0.21-1.fc38
$ rpm -qp --provides perl-Alien-m4-tests-0.21-1.fc38.noarch.rpm | sort | uniq -c
      1 perl-Alien-m4-tests = 0.21-1.fc38
Binary provides are Ok.

$ rpmlint ./perl-Alien-m4*
============================ rpmlint session starts ============================
rpmlint: 2.2.0
configuration:
    /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/licenses.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 4
perl-Alien-m4-tests.noarch: W: no-documentation
perl-Alien-m4.spec:39: W: comparison-operator-in-deptoken 2>/dev/null)
perl-Alien-m4.spec:39: W: comparison-operator-in-deptoken 2>/dev/null)
 3 packages and 1 specfiles checked; 0 errors, 3 warnings, 0 badness; has taken 0.3 s 
Rpmlint is ok

The package is in line with Fedora and Perl packaging guide lines.
Please correct 'FIX' item.

Resolution:
Approved

Comment 2 Petr Pisar 2022-10-06 14:55:12 UTC

Thanks for the review. You are right. The two dependencies was a copy-and-paste mistake. I corrected them.

https://pagure.io/releng/fedora-scm-requests/issue/47990

Comment 3 Gwyn Ciesla 2022-10-06 15:06:25 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Alien-m4