Bug 213180
| Summary: | Review Request: tcl-thread - Thread extension for Tcl | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Josh Boyer <jwboyer> | ||||
| Component: | Package Review | Assignee: | Wart <wart> | ||||
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Package Reviews List <fedora-package-review> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | ||||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2006-11-06 14:41:01 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 163779 | ||||||
| Attachments: |
|
||||||
|
Description
Josh Boyer
2006-10-31 02:24:39 UTC
This does not build properly on x86_64 in mock. It seems that the configure
script is written to only look for libgdbm.so in /usr/lib, not /usr/lib64. You
might try adding '--with-gdbm=%{_libdir}' to %configure, or modifying the
configure script to look for the library in ${libdir}.
Created attachment 140195 [details]
Look for gdbm library in %{_libdir}
This patch modifies the configure script to properly look for the gdbm library
in $libdir, instead of only looking in /usr/lib.
GOOD
====
* Package and spec named appropriately: The upstream name is the simply
'thread', which is far too generic. Following the examples for python
and perl modules, the name tcl-thread is acceptable.
* Spec file is legible and in Am. English
* Source matches upstream:
3c69b4a891590f23bb79a1fa98d879f7 thread2.6.5.tar.gz
* No unnecessary BuildRequires
* No locales
* No shared libraries in the default linker path; the shared library
that is produced is loaded by Tcl via dlopen.
* RPM_BUILD_ROOT cleaned where appropriate
* Not relocatable
* No duplicate %files
* File permissions look ok
* No need for a -devel subpackage
* Not a gui program; no need for a .desktop file
* Package loads into Tcl as expected and passes its own test suite.
* Consistent use of macros
* Does not own any directories that it should not own.
MUSTFIX
=======
* License does not match upstream. Should be BSD.
* License file 'license.terms' not included.
* Add the README and ChangeLog files to %doc
* Does not own all directories that it creates. In %files, change
%{_libdir}/thread%{version}/*
to
%{_libdir}/thread%{version}
* Does not build properly on x86_64 in mock. The attached patch
fixes the problem.
* The dependency on gdbm is picked up automatically. You can drop
Requires: gdbm.
SHOULDFIX
=========
* Missing a %check section for running the unit tests.
Thanks much for the review. I'll get those items fixed up, including the x86_64 issue, tomorrow. I should have fixed the MUSTFIXes before submitting, sorry about that. That's what I get for copying the initial spec from a different package. np. I'm a sucker for Tcl package reviews, and I'm interested to see how well this works with tclhttpd. Is there another review on the way that depends on this package? (In reply to comment #5) > np. I'm a sucker for Tcl package reviews, and I'm interested to see how well > this works with tclhttpd. Is there another review on the way that depends on > this package? Not as of yet. However the gitk author is probably going to use the Thread extention soon so that the main window is still responsive while another thread does the refresh/lookups. Ok, all comments should be fixed. Spec URL: http://jdub.homelinux.org/pub/tcl-thread.spec SRPM URL: http://jdub.homelinux.org/pub/tcl-thread-2.6.5-2.src.rpm Looks good. APPROVED |