Bug 2131934

Summary:	Enabling overprovision on a pool with overprovision already enabled should return an error.
Product:	Red Hat Enterprise Linux 9	Reporter:	Filip Suba <fsuba>
Component:	stratis-cli	Assignee:	Bryan Gurney <bgurney>
Status:	CLOSED ERRATA	QA Contact:	Filip Suba <fsuba>
Severity:	low	Docs Contact:
Priority:	medium
Version:	9.1	CC:	amulhern, cwei, dkeefe
Target Milestone:	rc	Keywords:	Triaged
Target Release:	9.2
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	stratis-cli-3.4.0-1.el9	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-05-09 07:41:26 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Filip Suba 2022-10-04 07:29:50 UTC

Description of problem:
Enabling overprovision on a pool with overprovision already enabled should return an error. A similar error message should be returned when user is trying to disable overprovision on a pool with overprovision already disabled.


Version-Release number of selected component (if applicable):
3.2.0

How reproducible:
100%


Steps to Reproduce:
1. stratis pool create test /dev/sda       
2. stratis pool overprovision test yes

Actual results:
No error is displayed.


Expected results:
Return an error with a message that overprovision is already enabled/disabled. 


Additional info:
# stratis pool create test /dev/sda
# stratis pool list
Name                Total / Used / Free    Properties                                   UUID   Alerts
test   9.10 TiB / 519.96 MiB / 9.10 TiB   ~Ca,~Cr, Op   2e4285d5-468a-43d9-bd1b-b3ef4cd10f7f
# stratis pool overprovision test yes
# stratis pool overprovision test no
# stratis pool list
Name                Total / Used / Free    Properties                                   UUID   Alerts
test   9.10 TiB / 519.96 MiB / 9.10 TiB   ~Ca,~Cr,~Op   2e4285d5-468a-43d9-bd1b-b3ef4cd10f7f
# stratis pool overprovision test no

Comment 1 mulhern 2022-10-04 20:14:06 UTC

Upstream: https://github.com/stratis-storage/stratis-cli/issues/915

Comment 5 Filip Suba 2022-12-05 11:53:29 UTC

Verified with stratis-cli-3.4.0-1.el9.

# stratis pool overprovision test yes
Execution failed:
It appears that you issued an unintended command: Pool's overprovision mode is already set to true

Comment 7 errata-xmlrpc 2023-05-09 07:41:26 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (stratis-cli bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2023:2273