Bug 2133001

Summary: hsxkpasswd-3.6-13.fc38 FTBFS: t/02-generate-passwords.t fails with perl-Type-Tiny-2.000001-1.fc38
Product: [Fedora] Fedora Reporter: Petr Pisar <ppisar>
Component: hsxkpasswdAssignee: Petr Pisar <ppisar>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: rc040203, zebob.m
Target Milestone: ---Keywords: Reopened
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: hsxkpasswd-3.6-14.fc38 hsxkpasswd-3.6-14.fc37 hsxkpasswd-3.6-12.fc36 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-01-17 01:35:59 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2117176    

Description Petr Pisar 2022-10-07 12:39:37 UTC
hsxkpasswd-3.6-13.fc38 fails to build in Fedora 38 because tests fail:

# Testing Crypt::HSXKPasswd v3.6, Perl 5.036000, /usr/bin/perl
t/00-load.t ................ ok
t/01-defined-constants.t ... ok
#   Failed test 'password generation with named argument 'dictionary_list''
#   at t/02-generate-passwords.t line 28.
#   Failed test 'password generation with named argument 'dictionary_file''
#   at t/02-generate-passwords.t line 35.
#   Failed test 'password generation with named arguments 'dictionary_file' & 'dictionary_file_encoding''
#   at t/02-generate-passwords.t line 41.
# Looks like you failed 3 tests of 10.
t/02-generate-passwords.t .. 
Dubious, test returned 3 (wstat 768, 0x300)
Failed 3/10 subtests 
t/manifest.t ............... skipped: Author tests not required for installation
t/perlcritic.t ............. skipped: Author test.  Set $ENV{TEST_AUTHOR} to a true value to run.
t/pod.t .................... skipped: Author tests not required for installation
Test Summary Report
-------------------
t/02-generate-passwords.t (Wstat: 768 (exited 3) Tests: 10 Failed: 3)
  Failed tests:  3-5
  Non-zero exit status: 3

A difference between passing and failing build root is at <https://koschei.fedoraproject.org/build/13816189>.

This failure is triggered by upgrading perl-Type-Tiny from 1.016010-1.fc37 to 2.000001-1.fc38.

Comment 1 Petr Pisar 2022-10-07 12:48:31 UTC
Type-Tiny bisected to a first bead commit:

commit 4baba12312f45d2e657468e26b64c643687651d1 (HEAD)
Author: Toby Inkster <mail.uk>
Date:   Sun Sep 11 19:16:15 2022 +0100

    Bring multisig functionality into the v2 API

Comment 2 Petr Pisar 2022-10-07 13:04:52 UTC
The new Type-Tiny raises an exception now:

$ perl -Ilib -e 'use Crypt::HSXKPasswd; Crypt::HSXKPasswd->new(dictionary_list => [qw(seme tes words)])'
Alternative signatures must be CODE, HASH, or ARRAY refs at /usr/share/perl5/vendor_perl/Type/Params/Signature.pm line 28.

Comment 3 Ralf Corsepius 2022-11-14 18:19:44 UTC
Petr, I think, hsxkpasswd should be retired, because it seems dead and unmaintained.

Checking what other distros do, I could not find any other distro, which ships it.

Comment 4 Robert-André Mauchin 🐧 2022-12-27 11:35:42 UTC
Sadly I retired it due to lack of upstream response.

Comment 5 Petr Pisar 2023-01-03 14:34:53 UTC
I think this package has not yet been retired from Fedora.

Today a bug report at upstream received a fix.

Comment 6 Ralf Corsepius 2023-01-06 16:07:39 UTC
> I think this package has not yet been retired from Fedora.
> 
> Today a bug report at upstream received a fix.
Would it be possible to have this fix in fc36 and fc37, too?

This bug is blocking me from applying updates/bug fixes to fc36 and fc37.

Comment 7 Petr Pisar 2023-01-06 16:39:38 UTC
Sure. I will do the builds.

Comment 8 Fedora Update System 2023-01-06 16:48:19 UTC
FEDORA-2023-f643ebf370 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-f643ebf370

Comment 9 Fedora Update System 2023-01-06 16:48:28 UTC
FEDORA-2023-c74ab55c24 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2023-c74ab55c24

Comment 10 Fedora Update System 2023-01-07 02:20:50 UTC
FEDORA-2023-f643ebf370 has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-f643ebf370`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-f643ebf370

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2023-01-07 02:21:28 UTC
FEDORA-2023-c74ab55c24 has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-c74ab55c24`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-c74ab55c24

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2023-01-17 01:35:59 UTC
FEDORA-2023-f643ebf370 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 13 Fedora Update System 2023-01-17 01:47:24 UTC
FEDORA-2023-c74ab55c24 has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.