Bug 2133261

Hit same issue on scsi disk when execute NTFS format  

Red Hat Enterprise Linux release 9.2 Beta (Plow)
5.14.0-162.el9.x86_64
qemu-kvm-7.1.0-1.el9.x86_64
seabios-bin-1.16.0-4.el9.noarch
edk2-ovmf-20220526git16779ede2d36-3.el9.noarch
libvirt-8.5.0-6.el9.x86_64
python3-libvirt-8.5.0-2.el9.x86_64
virtio-win-prewhql-0.1-225.iso


qemu-img create -f qcow2 /home/kvm_autotest_root/images/stg1.qcow2 10G


/usr/libexec/qemu-kvm \
     -name 'avocado-vt-vm1'  \
     -sandbox on  \
     -blockdev node-name=file_ovmf_code,driver=file,filename=/usr/share/OVMF/OVMF_CODE.secboot.fd,auto-read-only=on,discard=unmap \
     -blockdev node-name=drive_ovmf_code,driver=raw,read-only=on,file=file_ovmf_code \
     -blockdev node-name=file_ovmf_vars,driver=file,filename=/home/ovmf/OVMF_VARS.fd,auto-read-only=on,discard=unmap \
     -blockdev node-name=drive_ovmf_vars,driver=raw,read-only=off,file=file_ovmf_vars \
     -machine q35,memory-backend=mem-machine_mem,pflash0=drive_ovmf_code,pflash1=drive_ovmf_vars \
     -device pcie-root-port,id=pcie-root-port-0,multifunction=on,bus=pcie.0,addr=0x1,chassis=1 \
     -device pcie-pci-bridge,id=pcie-pci-bridge-0,addr=0x0,bus=pcie-root-port-0  \
     -nodefaults \
     -device VGA,bus=pcie.0,addr=0x2 \
     -m 12288 \
     -object memory-backend-ram,size=12288M,id=mem-machine_mem  \
     -smp 16,maxcpus=16,cores=8,threads=1,dies=1,sockets=2  \
     -cpu 'EPYC-Rome',x2apic=on,tsc-deadline=on,hypervisor=on,tsc-adjust=on,spec-ctrl=on,stibp=on,arch-capabilities=on,ssbd=on,xsaves=on,cmp-legacy=on,ibrs=on,amd-ssbd=on,virt-ssbd=on,lbrv=on,tsc-scale=on,vmcb-clean=on,svme-addr-chk=on,rdctl-no=on,skip-l1dfl-vmentry=on,mds-no=on,pschange-mc-no=on,hv_stimer,hv_synic,hv_vpindex,hv_relaxed,hv_spinlocks=0x1fff,hv_vapic,hv_time,hv_frequencies,hv_runtime,hv_tlbflush,hv_reenlightenment,hv_stimer_direct,hv_ipi,kvm_pv_unhalt=on \
     -chardev socket,id=qmp_id_qmpmonitor1,server=on,wait=off,path=/var/tmp/avocado_l20ses_2/monitor-qmpmonitor1-20220928-220503-Y6ZWjk2i  \
     -mon chardev=qmp_id_qmpmonitor1,mode=control \
     -chardev socket,id=qmp_id_catch_monitor,server=on,wait=off,path=/var/tmp/avocado_l20ses_2/monitor-catch_monitor-20220928-220503-Y6ZWjk2i  \
     -mon chardev=qmp_id_catch_monitor,mode=control \
     -device pvpanic,ioport=0x505,id=idGfvu9b \
     -chardev socket,id=chardev_serial0,server=on,wait=off,path=/var/tmp/avocado_l20ses_2/serial-serial0-20220928-220503-Y6ZWjk2i \
     -device isa-serial,id=serial0,chardev=chardev_serial0  \
     -chardev socket,id=seabioslog_id_20220928-220503-Y6ZWjk2i,path=/var/tmp/avocado_l20ses_2/seabios-20220928-220503-Y6ZWjk2i,server=on,wait=off \
     -device isa-debugcon,chardev=seabioslog_id_20220928-220503-Y6ZWjk2i,iobase=0x402 \
     -device pcie-root-port,id=pcie-root-port-1,port=0x1,addr=0x1.0x1,bus=pcie.0,chassis=2 \
     -device qemu-xhci,id=usb1,bus=pcie-root-port-1,addr=0x0 \
     -device usb-tablet,id=usb-tablet1,bus=usb1.0,port=1 \
     -object iothread,id=iothread0 \
     -object iothread,id=iothread1 \
     -device pcie-root-port,id=pcie-root-port-2,port=0x2,addr=0x1.0x2,bus=pcie.0,chassis=3 \
     -device virtio-scsi-pci,id=virtio_scsi_pci0,bus=pcie-root-port-2,addr=0x0,iothread=iothread0 \
     -blockdev node-name=file_image1,driver=file,auto-read-only=on,discard=unmap,aio=threads,filename=/home/kvm_autotest_root/images/win11-64-virtio-scsi.qcow2,cache.direct=on,cache.no-flush=off \
     -blockdev node-name=drive_image1,driver=qcow2,read-only=off,cache.direct=on,cache.no-flush=off,file=file_image1 \
     -device scsi-hd,id=image1,drive=drive_image1,write-cache=on \
     -blockdev node-name=file_stg1,driver=file,auto-read-only=on,discard=unmap,aio=threads,filename=/home/kvm_autotest_root/images/stg1.qcow2,cache.direct=on,cache.no-flush=off \
     -blockdev node-name=drive_stg1,driver=qcow2,read-only=off,cache.direct=on,cache.no-flush=off,file=file_stg1,discard=unmap \
     -device scsi-hd,id=stg1,drive=drive_stg1,write-cache=on \
     -device pcie-root-port,id=pcie-root-port-3,port=0x3,addr=0x1.0x3,bus=pcie.0,chassis=4 \
     -device virtio-net-pci,mac=9a:2f:74:a8:90:a1,id=idqBegdA,netdev=id0UWe8v,bus=pcie-root-port-3,addr=0x0  \
     -netdev tap,id=id0UWe8v,vhost=on \
     -blockdev node-name=file_cd1,driver=file,auto-read-only=on,discard=unmap,aio=threads,filename=/home/kvm_autotest_root/iso/windows/winutils.iso,cache.direct=on,cache.no-flush=off \
     -blockdev node-name=drive_cd1,driver=raw,read-only=on,cache.direct=on,cache.no-flush=off,file=file_cd1 \
     -device scsi-cd,id=cd1,drive=drive_cd1,write-cache=on \
     -blockdev node-name=file_virtio,driver=file,auto-read-only=on,discard=unmap,aio=threads,filename=/home/kvm_autotest_root/iso/windows/virtio-win-prewhql-0.1-225.iso,cache.direct=on,cache.no-flush=off \
     -blockdev node-name=drive_virtio,driver=raw,read-only=on,cache.direct=on,cache.no-flush=off,file=file_virtio \
     -device scsi-cd,id=virtio,drive=drive_virtio,write-cache=on  \
     -vnc :5  \
     -monitor stdio \
     -rtc base=localtime,clock=host,driftfix=slew  \
     -boot menu=off,order=cdn,once=c,strict=off \
     -chardev socket,id=char_vtpm_avocado-vt-vm1_tpm0,path=/home/kar/workspace/root/avocado/data/avocado-vt/swtpm/avocado-vt-vm1_tpm0_swtpm.sock \
     -tpmdev emulator,chardev=char_vtpm_avocado-vt-vm1_tpm0,id=emulator_vtpm_avocado-vt-vm1_tpm0 \
     -device tpm-crb,id=tpm-crb_vtpm_avocado-vt-vm1_tpm0,tpmdev=emulator_vtpm_avocado-vt-vm1_tpm0 \
     -enable-kvm \
     -device pcie-root-port,id=pcie_extra_root_port_0,multifunction=on,bus=pcie.0,addr=0x3,chassis=5

Hit the same issue with vioscsi + build 228 on RHEL9.1.z host.

Versions:
kernel-5.14.0-162.6.1.el9_1.x86_64
qemu-kvm-7.0.0-13.el9.x86_64
edk2-ovmf-20220526git16779ede2d36-3.el9.noarch
virtio-win-prewhql-228

Thanks~
Peixiu

Both reproduce both qcow2 and raw format.

Apparently W11 22H2 can perform only quick format on a thinly provisioning volume (https://bugzilla.redhat.com/attachment.cgi?id=1971081).
Windows can recognize such volume by checking ProvisioningType == PROVISIONING_TYPE_THIN
reported in VPD_LOGICAL_BLOCK_PROVISIONING VPD. in case of virtio-scsi the ProvisioningType
can be changed from PROVISIONING_TYPE_THIN to PROVISIONING_TYPE_RESOURCE by setting discard_granularity to 0.
virtio-blk driver sets ProvisioningType based on discard type but not on discard_granularity value, which 
makes it different from virtio-scsi. I prepared a patch for viostor driver to fix this difference and going to push it shoptly.

Meanwhile, can QE please check if setting discard_granularity to 0 can solve this issue for virtio-scsi
driver?

Thanks,
Vadim.

(In reply to Vadim Rozenfeld from comment #9)
> Apparently W11 22H2 can perform only quick format on a thinly provisioning
> volume (https://bugzilla.redhat.com/attachment.cgi?id=1971081).
> Windows can recognize such volume by checking ProvisioningType ==
> PROVISIONING_TYPE_THIN
> reported in VPD_LOGICAL_BLOCK_PROVISIONING VPD. in case of virtio-scsi the
> ProvisioningType
> can be changed from PROVISIONING_TYPE_THIN to PROVISIONING_TYPE_RESOURCE by
> setting discard_granularity to 0.
> virtio-blk driver sets ProvisioningType based on discard type but not on
> discard_granularity value, which 
> makes it different from virtio-scsi. I prepared a patch for viostor driver
> to fix this difference and going to push it shoptly.
Thanks for explanation!

> Meanwhile, can QE please check if setting discard_granularity to 0 can solve
> this issue for virtio-scsi
> driver?
Test virtio-scsi with 237 build with discard_granularity=0, it can format success.

-blockdev '{"node-name": "file_stg1", "driver": "file", "auto-read-only": true, "discard": "unmap", "aio": "threads", "filename": "/home/kvm_autotest_root/images/stg1.qcow2", "cache": {"direct": true, "no-flush": false}}' \
-blockdev '{"node-name": "drive_stg1", "driver": "qcow2", "read-only": false, "cache": {"direct": true, "no-flush": false}, "file": "file_stg1", "discard": "unmap"}' \
-device scsi-hd,id=stg1,drive=drive_stg1,write-cache=on,discard_granularity=0 \


> Thanks,
> Vadim.

post upstream https://github.com/virtio-win/kvm-guest-drivers-windows/pull/927

virio-blk fix available in build 238
https://brewweb.engineering.redhat.com/brew/buildinfo?buildID=2557016

please try with discard_granularity=0 and discard_granularity=32M
it should behave the same way as vioscsi
Thanks,
Vadim.