Bug 2133273

Summary: rpmconf -c check all directories because of /var/run/host symlink
Product: [Fedora] Fedora Reporter: Markus Linnala <markus.linnala>
Component: rpmconfAssignee: Miroslav Suchý <msuchy>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 37CC: msuchy, xjakub
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: rpmconf-1.1.7-1.fc36.1 rpmconf-1.1.7-1.el8.1 rpmconf-1.1.7-1.el7.1 rpmconf-1.1.7-1.fc35.1 rpmconf-1.1.7-1.fc37.1 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-10-14 12:58:14 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Markus Linnala 2022-10-09 11:22:18 UTC 
Description of problem:

At F37 rpmconf -c does not work as documented it follows /var/run/host symlink and ends up checking all directories.

Version-Release number of selected component (if applicable):

rpmconf-1.1.4-6.fc37.noarch

How reproducible:


Steps to Reproduce:
1. sudo rpmconf -c

Actual results:

Job takes long time (at least tens of minutes) and I ended up stopping with C-c. I assume it loops /var/run/host again and again.


Expected results:

I get some results and job stops after some time. My run in F36 takes less than 20 seconds, so this is regression.

Additional Info:

-x option does not seem to work as I am not able to exclude /var/run for example.

You can debug it by:

% sudo strace -f rpmconf -c -x /var/run
...
openat(AT_FDCWD, "/var/run/host/home", O_RDONLY|O_NONBLOCK|O_CLOEXEC|O_DIRECTORY) = 6
openat(AT_FDCWD, "/var/run/host/home/lost+found", O_RDONLY|O_NONBLOCK|O_CLOEXEC|O_DIRECTORY) = 6
Comment 1 Miroslav Suchý 2022-10-10 11:17:26 UTC 
Thank you for the report.

I fixed it twice: this (and several other) path is excluded now.
And the code now checks for the loops during traversal and do not continue in directories where it was already.
Comment 2 Fedora Update System 2022-10-10 11:28:18 UTC 
FEDORA-EPEL-2022-3b51e8ba69 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2022-3b51e8ba69
Comment 3 Fedora Update System 2022-10-10 11:28:19 UTC 
FEDORA-2022-10767d096a has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-10767d096a
Comment 4 Fedora Update System 2022-10-10 11:28:20 UTC 
FEDORA-2022-b246e4fe4a has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-b246e4fe4a
Comment 5 Fedora Update System 2022-10-10 11:28:21 UTC 
FEDORA-2022-0ec7e5948c has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-0ec7e5948c
Comment 6 Fedora Update System 2022-10-10 11:28:22 UTC 
FEDORA-EPEL-2022-f611ee30d4 has been submitted as an update to Fedora EPEL 8. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2022-f611ee30d4
Comment 7 Fedora Update System 2022-10-11 08:22:04 UTC 
FEDORA-2022-0ec7e5948c has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-0ec7e5948c`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-0ec7e5948c

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
Comment 8 Fedora Update System 2022-10-11 10:59:36 UTC 
FEDORA-EPEL-2022-3b51e8ba69 has been pushed to the Fedora EPEL 7 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2022-3b51e8ba69

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
Comment 9 Fedora Update System 2022-10-11 11:51:31 UTC 
FEDORA-EPEL-2022-f611ee30d4 has been pushed to the Fedora EPEL 8 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2022-f611ee30d4

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
Comment 10 Fedora Update System 2022-10-11 12:04:42 UTC 
FEDORA-2022-10767d096a has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-10767d096a`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-10767d096a

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
Comment 11 Fedora Update System 2022-10-11 12:12:38 UTC 
FEDORA-2022-b246e4fe4a has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-b246e4fe4a`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-b246e4fe4a

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
Comment 12 Fedora Update System 2022-10-14 12:58:14 UTC 
FEDORA-2022-b246e4fe4a has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.
Comment 13 Fedora Update System 2022-10-18 15:16:43 UTC 
FEDORA-EPEL-2022-f611ee30d4 has been pushed to the Fedora EPEL 8 stable repository.
If problem still persists, please make note of it in this bug report.
Comment 14 Fedora Update System 2022-10-18 15:29:47 UTC 
FEDORA-EPEL-2022-3b51e8ba69 has been pushed to the Fedora EPEL 7 stable repository.
If problem still persists, please make note of it in this bug report.
Comment 15 Fedora Update System 2022-10-18 15:43:22 UTC 
FEDORA-2022-10767d096a has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.
Comment 16 Fedora Update System 2022-11-10 22:14:12 UTC 
FEDORA-2022-0ec7e5948c has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.