Bug 2133428

Summary: Error compiling code with libunwind-devel on aarch64: error: expected identifier before numeric constant
Product: [Fedora] Fedora Reporter: Jaroslav Škarvada <jskarvad>
Component: libunwindAssignee: Carlos O'Donell <codonell>
Status: CLOSED NOTABUG QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: codonell, fweimer, jan, jes.sorensen, mcermak, spotrh
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-10-10 11:47:18 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Jaroslav Škarvada 2022-10-10 11:42:43 UTC
Description of problem:
Compilation fails on aarch64, reproducer with e.g. roc-toolkit.

Version-Release number of selected component (if applicable):
libunwind-devel-1.6.2-5.fc38

How reproducible:
Always

Steps to Reproduce:
1. fedpkg co roc-toolkit
2. drop excludearch for aarch64
3. fedpkg scratch-build --srpm --arches aarch64

Actual results:
In file included from /usr/include/libunwind.h:5,
                 from src/modules/roc_core/target_libunwind/roc_core/backtrace.cpp:10:
/usr/include/libunwind-aarch64.h:198:17: error: expected identifier before numeric constant
  198 |         alignas(16) uint8_t __reserved[(66 * 8)];
      |                 ^~
/usr/include/libunwind-aarch64.h:198:17: error: expected ‘,’ or ‘...’ before numeric constant
/usr/include/libunwind-aarch64.h:198:19: error: expected ‘;’ at end of member declaration
  198 |         alignas(16) uint8_t __reserved[(66 * 8)];
      |                   ^
      |                    ;


Expected results:
No error

Additional info:
It's probably related to this upstream commit:
https://github.com/libunwind/libunwind/pull/186/commits/e72fe5376e7084017d8f56ecdfea3d4766e5e3fb

Comment 1 Jaroslav Škarvada 2022-10-10 11:43:08 UTC
Full build log:
https://kojipkgs.fedoraproject.org//work/tasks/5793/92875793/build.log

Comment 2 Jaroslav Škarvada 2022-10-10 11:47:18 UTC
Hmm, it's using -std=c++98.

Sorry for noise.