Bug 2133468

If you apply this patch, does the migration work? 


Untitled
From WebUI, 25 Minutes ago, written in Diff-output.
This paste will explode in 23 Hours.	
URL https://paste.centos.org/view/6bc966bb
Embed Show code
Download Paste or View Raw

        diff --git a/pulp_rpm/app/migrations/0044_noartifact_modules.py b/pulp_rpm/app/migrations/0044_noartifact_modules.py
        index 7bedf12d..6e65976e 100644
        --- a/pulp_rpm/app/migrations/0044_noartifact_modules.py
        +++ b/pulp_rpm/app/migrations/0044_noartifact_modules.py
        @@ -18,7 +18,7 @@ def convert_artifact_to_snippets(apps, schema_editor):
                 for module in Modulemd.objects.all():
                     artifact = module._artifacts.get()
                     module.snippet = artifact.file.read().decode("utf-8")
        -            content_artifact = ContentArtifact.objects.get(artifact__pk=artifact.pk)
        +            content_artifact = ContentArtifact.objects.get(artifact__pk=artifact.pk, content__pk=module.pk)
                     content_artifacts_to_delete.append(content_artifact.pk)
                     artifacts_to_delete.append(artifact.pk)
                     modules_with_snippet.append(module)
        @@ -26,7 +26,7 @@ def convert_artifact_to_snippets(apps, schema_editor):
                 for default in ModulemdDefaults.objects.all():
                     artifact = default._artifacts.get()
                     default.snippet = artifact.file.read().decode("utf-8")
        -            content_artifact = ContentArtifact.objects.get(artifact__pk=artifact.pk)
        +            content_artifact = ContentArtifact.objects.get(artifact__pk=artifact.pk, content__pk=default.pk)
                     content_artifacts_to_delete.append(content_artifact.pk)
                     artifacts_to_delete.append(artifact.pk)
                     defaults_with_snippet.append(default)

The proposed patch does not work

# wget -O- https://paste.centos.org/view/download/6bc966bb |  patch -N -p1 -d /usr/lib/python3.9/site-packages
# su - pulp -s /bin/bash
$ PULP_SETTINGS=/etc/pulp/settings.py pulpcore-manager migrate
System check identified some issues:

WARNINGS:
?: (guardian.W001) Guardian authentication backend is not hooked. You can add this in settings as eg: `AUTHENTICATION_BACKENDS = ('django.contrib.auth.backends.ModelBackend', 'guardian.backends.ObjectPermissionBackend')`.
Operations to perform:
  Apply all migrations: admin, ansible, auth, certguard, container, contenttypes, core, file, guardian, rpm, sessions
Running migrations:
  Applying rpm.0044_noartifact_modules...Traceback (most recent call last):
  File "/usr/bin/pulpcore-manager", line 33, in <module>
    sys.exit(load_entry_point('pulpcore==3.18.10', 'console_scripts', 'pulpcore-manager')())
  File "/usr/lib/python3.9/site-packages/pulpcore/app/manage.py", line 11, in manage
    execute_from_command_line(sys.argv)
  File "/usr/lib/python3.9/site-packages/django/core/management/__init__.py", line 419, in execute_from_command_line
    utility.execute()
  File "/usr/lib/python3.9/site-packages/django/core/management/__init__.py", line 413, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File "/usr/lib/python3.9/site-packages/django/core/management/base.py", line 354, in run_from_argv
    self.execute(*args, **cmd_options)
  File "/usr/lib/python3.9/site-packages/django/core/management/base.py", line 398, in execute
    output = self.handle(*args, **options)
  File "/usr/lib/python3.9/site-packages/django/core/management/base.py", line 89, in wrapped
    res = handle_func(*args, **kwargs)
  File "/usr/lib/python3.9/site-packages/django/core/management/commands/migrate.py", line 244, in handle
    post_migrate_state = executor.migrate(
  File "/usr/lib/python3.9/site-packages/django/db/migrations/executor.py", line 117, in migrate
    state = self._migrate_all_forwards(state, plan, full_plan, fake=fake, fake_initial=fake_initial)
  File "/usr/lib/python3.9/site-packages/django/db/migrations/executor.py", line 147, in _migrate_all_forwards
    state = self.apply_migration(state, migration, fake=fake, fake_initial=fake_initial)
  File "/usr/lib/python3.9/site-packages/django/db/migrations/executor.py", line 227, in apply_migration
    state = migration.apply(state, schema_editor)
  File "/usr/lib/python3.9/site-packages/django/db/migrations/migration.py", line 126, in apply
    operation.database_forwards(self.app_label, schema_editor, old_state, project_state)
  File "/usr/lib/python3.9/site-packages/django/db/migrations/operations/special.py", line 190, in database_forwards
    self.code(from_state.apps, schema_editor)
  File "/usr/lib/python3.9/site-packages/pulp_rpm/app/migrations/0044_noartifact_modules.py", line 45, in convert_artifact_to_snippets
    Artifact.objects.filter(pk__in=artifacts_to_delete).delete()
  File "/usr/lib/python3.9/site-packages/django/db/models/query.py", line 745, in delete
    collector.collect(del_query)
  File "/usr/lib/python3.9/site-packages/django/db/models/deletion.py", line 302, in collect
    raise ProtectedError(
django.db.models.deletion.ProtectedError: ("Cannot delete some instances of model 'Artifact' because they are referenced through protected foreign keys: 'ContentArtifact.artifact'.", {<ContentArtifact: ContentArtifact object (fed4acbe-e8a2-4a96-8aba-893d32e28fa7)>})

VERIFIED.

@Satellite 6.12.0 Snap15
python39-pulp-rpm-3.18.7-1.el8pc.noarch

by using Upgrades Automation as the BZ was originally reproduced here:

upgrade-phase job with Satellite and Capsule scenario

>>> upgrade from 6.11.z to 6.12.0 passed successfully

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: Satellite 6.12 Release), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:8506

The Pulp upstream bug status is at closed. Updating the external tracker on this bug.