Bug 2133872

Summary: Review Request: python-mistune08 - Markdown parser for Python
Product: [Fedora] Fedora Reporter: Michel Lind <michel>
Component: Package ReviewAssignee: Davide Cavalca <davide>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: davide, mhroncok, package-review
Target Milestone: ---Flags: davide: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-10-12 17:02:21 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2113619    

Description Michel Lind 2022-10-11 17:03:39 UTC
Spec URL: https://salimma.fedorapeople.org/python-mistune08.spec
SRPM URL: https://salimma.fedorapeople.org/python-mistune08-0.8.4-6.fc37.src.rpm

Description:
The fastest markdown parser in pure Python, inspired by marked.

Fedora Account System Username: salimma

Comment 1 Michel Lind 2022-10-11 17:05:09 UTC
Diff from last python-mistune commit:
https://pagure.io/michel-slm/python-mistune08/c/65afa0a7fa357b83b8a9d32f722dfeb2bf545887?branch=rawhide

Verify that we can't install both mistune and mistune08 side by side:

python-mistune08 on  rawhide [?⇡] via 🐍 v3.11.0rc1 (.venv311) took 1m5s 
⬢ [fedora-toolbox:37] ❯ sudo dnf install ~/repos/mailman/results/fedora-37-x86_64/python-mistune08-0.8.4-6.fc37/python3-mistune08-0.8.4-6.fc37.noarch.rpm python3-mistune
Fedora 37 - x86_64                               25 kB/s |  12 kB     00:00    
Fedora 37 - x86_64                              540 kB/s | 2.8 MB     00:05    
Fedora Modular 37 - x86_64                       50 kB/s |  19 kB     00:00    
Fedora Modular 37 - x86_64                      148 kB/s | 175 kB     00:01    
Fedora 37 - x86_64 - Updates                     80 kB/s |  22 kB     00:00    
Fedora Modular 37 - x86_64 - Updates             77 kB/s |  21 kB     00:00    
Fedora 37 - x86_64 - Test Updates                26 kB/s |  13 kB     00:00    
Fedora 37 - x86_64 - Test Updates               413 kB/s | 1.8 MB     00:04    
Fedora Modular 37 - x86_64 - Test Updates        55 kB/s |  15 kB     00:00    
Fedora Modular 37 - x86_64 - Test Updates       121 kB/s | 122 kB     00:01    
Error: 
 Problem: package python3-mistune08-0.8.4-6.fc37.noarch conflicts with python3-mistune provided by python3-mistune-0.8.4-5.fc37.noarch
  - conflicting requests
(try to add '--allowerasing' to command line to replace conflicting packages or '--skip-broken' to skip uninstallable packages)

Comment 2 Michel Lind 2022-10-11 17:07:10 UTC
needed because nbconvert still needs Mistune < 2

python-mistune08 on  rawhide [?] via 🐍 v3.11.0rc1 (.venv311) 
⬢ [fedora-toolbox:37] ❯ sudo dnf repoquery --requires python3-nbconvert | grep mistune
Last metadata expiration check: 0:07:48 ago on Tue 11 Oct 2022 11:59:01 AM CDT.

Comment 3 Davide Cavalca 2022-10-11 17:08:15 UTC
This is a compat package, diff looks sane and usage complies with policy, APPROVED

Comment 4 Michel Lind 2022-10-11 17:11:08 UTC
Let's see if requesting with '--exception' works

❯ fedpkg request-repo --exception --no-initial-commit python-mistune08 
https://pagure.io/releng/fedora-scm-requests/issue/48141

Comment 5 Michel Lind 2022-10-11 17:25:21 UTC
python-mistune08 on  rawhide [?] via 🐍 v3.11.0rc1 (.venv311) 
⬢ [fedora-toolbox:37] ❯ fedpkg request-branch --repo python-mistune08 --all-releases
https://pagure.io/releng/fedora-scm-requests/issue/48142
https://pagure.io/releng/fedora-scm-requests/issue/48143
https://pagure.io/releng/fedora-scm-requests/issue/48144

python-mistune08 on  rawhide [?] via 🐍 v3.11.0rc1 (.venv311) took 11s 
⬢ [fedora-toolbox:37] ❯ fedpkg request-branch --repo python-mistune08 epel9

Comment 6 Fedora Update System 2022-10-12 15:42:43 UTC
FEDORA-EPEL-2022-7da468cb03 has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2022-7da468cb03

Comment 7 Fedora Update System 2022-10-12 15:42:43 UTC
FEDORA-2022-151e9e3680 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-151e9e3680

Comment 8 Fedora Update System 2022-10-12 15:42:44 UTC
FEDORA-2022-687f046b74 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-687f046b74

Comment 9 Miro Hrončok 2022-10-12 16:12:53 UTC
This cannot be just packaged for stable releases without a figured update path.


If you plan to update python-mistune in stable releases, this needs to Obsolete the older version so it is replaced without --alowerasing.

If you don't plan to update python-mistune in stable releases, this should have not been imported there.


------------

This probably needs to be removed or updated:

            %{?python_provide:%python_provide python3-%{upname}}

https://src.fedoraproject.org/rpms/python-mistune08/pull-request/1

Comment 10 Miro Hrončok 2022-10-12 16:14:18 UTC
python-m2r requires python3dist(mistune) without a version range. Are we 100% sure we can update mistune without breaking this package?

Comment 11 Fedora Update System 2022-10-12 16:24:04 UTC
FEDORA-2022-687f046b74 has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-687f046b74 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-687f046b74

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2022-10-12 17:02:21 UTC
FEDORA-EPEL-2022-7da468cb03 has been pushed to the Fedora EPEL 9 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 13 Fedora Update System 2022-10-12 17:51:24 UTC
FEDORA-2022-151e9e3680 has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-151e9e3680 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-151e9e3680

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 14 Fedora Update System 2022-10-12 18:15:33 UTC
FEDORA-2022-e5598dddfd has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-e5598dddfd \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-e5598dddfd

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 15 Miro Hrončok 2022-10-12 18:35:55 UTC
I also don't understand why the package name is python-mistune08 and not python-mistune0.8. See the examples at https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#multiple

But I guess it's too late for that now :(

Comment 16 Fedora Update System 2022-10-14 10:30:54 UTC
FEDORA-2022-e4f5866111 has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-e4f5866111`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-e4f5866111

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 17 Fedora Update System 2022-11-10 22:17:00 UTC
FEDORA-2022-e4f5866111 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.