Bug 2137364
| Summary: | composer-cli blueprints show command fails when firewall customization is included in a blueprint | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 9 | Reporter: | Mario Cattamo <mcattamo> |
| Component: | osbuild-composer | Assignee: | Brian Lane <bcl> |
| Status: | CLOSED ERRATA | QA Contact: | Release Test Team <release-test-team-automation> |
| Severity: | low | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 9.1 | CC: | atodorov, idiez, obudai, thozza |
| Target Milestone: | rc | Keywords: | Patch, Triaged, Upstream |
| Target Release: | --- | ||
| Hardware: | x86_64 | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | osbuild-composer-67-2.el9 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2023-05-09 07:32:45 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Mario Cattamo
2022-10-24 15:22:16 UTC
I can also reproduce this on the upstream version running on Fedora 36, it looks like the toml library is having some problems with the blueprint. The server panics with:
Oct 24 15:29:22 fedora osbuild-composer[556]: 2022/10/24 15:29:22 GET /api/v1/blueprints/info/ostree
Oct 24 15:29:22 fedora osbuild-composer[556]: 2022/10/24 15:29:22 http: panic serving @: runtime error: comparing uncomparable type blueprint.FirewallCustomization
Oct 24 15:29:22 fedora osbuild-composer[556]: goroutine 58 [running]:
Oct 24 15:29:22 fedora osbuild-composer[556]: net/http.(*conn).serve.func1()
Oct 24 15:29:22 fedora osbuild-composer[556]: /usr/lib/golang/src/net/http/server.go:1825 +0xbf
Oct 24 15:29:22 fedora osbuild-composer[556]: panic({0x55d51babc800, 0xc00034e1f0})
Oct 24 15:29:22 fedora osbuild-composer[556]: /usr/lib/golang/src/runtime/panic.go:844 +0x258
Oct 24 15:29:22 fedora osbuild-composer[556]: github.com/osbuild/osbuild-composer/vendor/github.com/BurntSushi/toml.(*Encoder).safeEncode.func1()
Oct 24 15:29:22 fedora osbuild-composer[556]: /home/bcl/Red_Hat/projs/osbuild-composer/rpmbuild/BUILD/osbuild-composer-f42da31362f8f100ac4ad92e470eb2ab6891f48f/_build/src/github.com/osbuild/osbuild-comp>
Oct 24 15:29:22 fedora osbuild-composer[556]: panic({0x55d51babc800, 0xc00034e1f0})
I think this is a new "feature" of the BurntSushi/toml library. See this commit for the first case when it broke us: https://github.com/osbuild/osbuild-composer/pull/2925/commits/b6297c9c12cd1ec38405ea4b1b81326c016f1b3e Brian, can you have a look, please? # rpm -q osbuild-composer osbuild-composer-73-1.el9.x86_64 # cat firewall.toml name = "ostree" description = "A base ostree image TEST" version = "0.0.1" modules = [] groups = [] [[packages]] name = "python3" version = "*" [customizations.firewall] ports = ["22:tcp", "80:tcp", "imap:tcp", "53:tcp", "53:udp"] [customizations.firewall.services] enabled = ["ftp", "ntp", "dhcp"] disabled = ["telnet"] ^^^ no newline at the end but that shouldn't matter. # composer-cli blueprints push firewall.toml # composer-cli blueprints list ostree # composer-cli blueprints show ostree name = "ostree" description = "A base ostree image TEST" version = "0.0.1" modules = [] groups = [] distro = "" [[packages]] name = "python3" version = "*" [customizations] [customizations.firewall] ports = ["22:tcp", "80:tcp", "imap:tcp", "53:tcp", "53:udp"] [customizations.firewall.services] enabled = ["ftp", "ntp", "dhcp"] disabled = ["telnet"] No errors. Moving to VERIFIED. *** Bug 2178206 has been marked as a duplicate of this bug. *** Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (Moderate: Image Builder security, bug fix, and enhancement update), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2023:2204 |