Bug 2137365

Summary:	Review Request: perl-Graphics-Toolkit-Color - Color palette creation tool
Product:	[Fedora] Fedora	Reporter:	Petr Pisar <ppisar>
Component:	Package Review	Assignee:	Petr Salaba <psalaba>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	package-review, psalaba
Target Milestone:	---	Flags:	psalaba: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	perl-Graphics-Toolkit-Color-1.00-1.fc38	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-11-08 15:36:14 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2137026

Description Petr Pisar 2022-10-24 15:30:27 UTC

Spec URL: https://ppisar.fedorapeople.org/perl-Graphics-Toolkit-Color/perl-Graphics-Toolkit-Color.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Graphics-Toolkit-Color/perl-Graphics-Toolkit-Color-1.00-1.fc38.src.rpm
Description:
Each object has 7 attributes, which are its RGB and HSL values and if
possible a name. This is because humans access colors on hardware level
(eye) in RGB, on cognition level in HSL (brain) and on cultural level
(language) with names. Having easy access to all three and some color math
should enable you to get the color palette you desire quickly and with no
additional dependencies.

Fedora Account System Username: ppisar

Comment 1 Petr Salaba 2022-11-08 12:59:28 UTC

Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
BuildArch is ok
BuildRequires are ok
Files section is ok
All tests passed

$ rpmlint perl-Graphics-Toolkit-Color*.{spec,rpm}
===================================== rpmlint session starts =====================================
rpmlint: 2.2.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/licenses.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 4

perl-Graphics-Toolkit-Color-tests.noarch: W: no-documentation
====== 3 packages and 1 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.2 s ======
rpmlint output is ok

$ rpm -q -lv -p perl-Graphics-Toolkit-Color-1.00-1.fc38.noarch.rpm 
drwxr-xr-x    2 root     root                        0 Nov  8 12:53 /usr/share/doc/perl-Graphics-Toolkit-Color
-rw-r--r--    1 root     root                      457 Oct  4 23:46 /usr/share/doc/perl-Graphics-Toolkit-Color/CONTRIBUTING
-rw-r--r--    1 root     root                      148 Oct  4 23:46 /usr/share/doc/perl-Graphics-Toolkit-Color/Changes
-rw-r--r--    1 root     root                    11735 Oct  4 23:46 /usr/share/doc/perl-Graphics-Toolkit-Color/README
drwxr-xr-x    2 root     root                        0 Nov  8 12:53 /usr/share/licenses/perl-Graphics-Toolkit-Color
-rw-r--r--    1 root     root                    18419 Oct  4 23:46 /usr/share/licenses/perl-Graphics-Toolkit-Color/LICENSE
-rw-r--r--    1 root     root                     5824 Nov  8 12:53 /usr/share/man/man3/Graphics::Toolkit::Color.3pm.gz
-rw-r--r--    1 root     root                     5722 Nov  8 12:53 /usr/share/man/man3/Graphics::Toolkit::Color::Constant.3pm.gz
-rw-r--r--    1 root     root                     2229 Nov  8 12:53 /usr/share/man/man3/Graphics::Toolkit::Color::Value.3pm.gz
drwxr-xr-x    2 root     root                        0 Nov  8 12:53 /usr/share/perl5/vendor_perl/Graphics
drwxr-xr-x    2 root     root                        0 Nov  8 12:53 /usr/share/perl5/vendor_perl/Graphics/Toolkit
drwxr-xr-x    2 root     root                        0 Nov  8 12:53 /usr/share/perl5/vendor_perl/Graphics/Toolkit/Color
-rw-r--r--    1 root     root                    22429 Oct  4 23:46 /usr/share/perl5/vendor_perl/Graphics/Toolkit/Color.pm
-rw-r--r--    1 root     root                    64976 Oct  4 23:46 /usr/share/perl5/vendor_perl/Graphics/Toolkit/Color/Constant.pm
-rw-r--r--    1 root     root                     8899 Oct  4 23:46 /usr/share/perl5/vendor_perl/Graphics/Toolkit/Color/Value.pm
$ rpm -q -lv -p perl-Graphics-Toolkit-Color-tests-1.00-1.fc38.noarch.rpm 
drwxr-xr-x    2 root     root                        0 Nov  8 12:53 /usr/libexec/perl-Graphics-Toolkit-Color
drwxr-xr-x    2 root     root                        0 Oct  4 23:46 /usr/libexec/perl-Graphics-Toolkit-Color/t
-rwxr-xr-x    1 root     root                    10873 Oct  4 23:46 /usr/libexec/perl-Graphics-Toolkit-Color/t/01_color_value.t
-rwxr-xr-x    1 root     root                     6554 Oct  4 23:46 /usr/libexec/perl-Graphics-Toolkit-Color/t/02_color_constant.t
-rwxr-xr-x    1 root     root                    31215 Oct  4 23:46 /usr/libexec/perl-Graphics-Toolkit-Color/t/03_color.t
-rwxr-xr-x    1 root     root                      111 Nov  8 12:53 /usr/libexec/perl-Graphics-Toolkit-Color/test
File layout and permissions are ok

$ rpm -qp --requires perl-Graphics-Toolkit-Color-1.00-1.fc38.src.rpm | sort | uniq -c | grep -v rpmlib
      1 coreutils
      1 make
      1 perl(Carp) >= 1.35
      1 perl(Exporter) >= 5
      1 perl(ExtUtils::MakeMaker) >= 6.76
      1 perl-generators
      1 perl-interpreter
      1 perl(strict)
      1 perl(Test::More) >= 1.3
      1 perl(Test::Warn) >= 0.30
      1 perl(:VERSION) >= 5.12.0
      1 perl(warnings)
SRPM requires are ok

$ rpm -qp --requires perl-Graphics-Toolkit-Color-1.00-1.fc38.noarch.rpm | sort | uniq -c | grep -v rpmlib
      1 perl(Carp) >= 1.35
      1 perl(Exporter) >= 5
      1 perl(Graphics::Toolkit::Color::Constant)
      1 perl(Graphics::Toolkit::Color::Value)
      1 perl(:MODULE_COMPAT_5.36.0)
      1 perl(:VERSION) >= 5.12.0
$ rpm -qp --requires perl-Graphics-Toolkit-Color-tests-1.00-1.fc38.noarch.rpm | sort | uniq -c | grep -v rpmlib
      1 perl-Graphics-Toolkit-Color = 1.00-1.fc38
      1 perl-Test-Harness
      1 perl(Test::More) >= 1.3
      1 perl(Test::Warn) >= 0.30
      1 perl(:VERSION) >= 5.12.0
      1 perl(warnings)
      1 /usr/bin/perl
      1 /usr/bin/sh
Binary requires are ok

$ rpm -qp --provides perl-Graphics-Toolkit-Color-1.00-1.fc38.noarch.rpm | sort | uniq -c
      1 perl(Graphics::Toolkit::Color) = 1.00
      1 perl-Graphics-Toolkit-Color = 1.00-1.fc38
      1 perl(Graphics::Toolkit::Color::Constant)
      1 perl(Graphics::Toolkit::Color::Value)
$ rpm -qp --provides perl-Graphics-Toolkit-Color-tests-1.00-1.fc38.noarch.rpm | sort | uniq -c
      1 perl-Graphics-Toolkit-Color-tests = 1.00-1.fc38
Binary provides are ok

Resolution: Package APPROVED

Comment 2 Petr Pisar 2022-11-08 14:53:21 UTC

https://pagure.io/releng/fedora-scm-requests/issue/48893

Comment 3 Gwyn Ciesla 2022-11-08 15:01:37 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Graphics-Toolkit-Color

Comment 4 Petr Pisar 2022-11-08 15:23:06 UTC

Thank you for the review and the repository.