Bug 213807
| Summary: | [QLogic RHEL5.0B2] patch to add support for qla4032 for qla4xxx driver | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 5 | Reporter: | David Somayajulu <david.somayajulu> | ||||||
| Component: | kernel | Assignee: | Mike Christie <mchristi> | ||||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Brian Brock <bbrock> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | medium | ||||||||
| Version: | 5.0 | CC: | andriusb, coughlan, david.somayajulu, jjarvis, jturner, mchristi, qlogic-redhat-ext, rkenna | ||||||
| Target Milestone: | --- | Keywords: | FutureFeature | ||||||
| Target Release: | --- | ||||||||
| Hardware: | All | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | 5.0.0 | Doc Type: | Enhancement | ||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2007-01-23 12:03:34 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | 215641, 216255 | ||||||||
| Bug Blocks: | 216985 | ||||||||
| Attachments: |
|
||||||||
|
Description
David Somayajulu
2006-11-03 02:51:59 UTC
Created attachment 140206 [details]
patch to add support for qla4032 for qla4xxx driver
David, is this an entirely new card with new PCI IDs, and therefore a new entry in mkinitrd/anaconda? Also, is this patch upstream? This request was evaluated by Red Hat Product Management for inclusion in a Red Hat Enterprise Linux release. Product Management has requested further review of this request by Red Hat Engineering. This request is not yet committed for inclusion in release. This is the patch we told them we could not merge right now because it was too late - way past new feature deadlone. The kernel patch is not upstream. Did qlogic assign this to the anaconda team? Oh yeah the patch is pretty harmless. I mean not much chance for regressions. This one feels way too late to me. There's far too much code change here to pull in this late in the cycle and too much testing (any testing with older cards supported by this driver) would be invalidated. QE nak. Action for QLogic : Our Quality Engineering group has just evaluated the proposed patch and is very hesitant to include it for RHEL 5.0 GA for the following reasons: * Possible problems with the patch, per Mike Christie * Possible regressions with older QLogic cards * This is a feature request, and it is very very late. The patch includes more items other than simple userspace PCI ID addtions/changes. * Is this patch being driven more by QLogic or IBM? Assuming the problems Mike found are resolved easily, Red Hat would like to see an agressive test plan for the older cards. This is by far the most important factor. At this point the patch is not committed by all Red Hat groups for inclusion in RHEL 5. Created attachment 142793 [details] rejenerated patch against root of kernel source tree The problem that Mike observe was due to a bug in the ioctl module. Please use the ioctl module at ftp://ftp.qlogic.com/outgoing/linux/iSCSI/qisioctl/v2.00.01.b1/ Also this patch is now dependant on the inclusion of the following patches. Bugzilla Bug 215641: Patch to fix reset issue when ethernet interface is enabled. Bugzilla Bug 216255: qla4xxx: fix timing issue for nvram accesses David, if you don't notify (add to CC-list) Tom or me of new bugs as listed in Comment #20, they aren't guaranteed to get on anyone's radar screens. Trung V Nguyen - IBM System x networking/iSCSI products development System x plans to release QLogic QLE406xC HBAs, for System x, during mid May 07 to mid June 07. RH levels supported are RHEL 4.x and 5.x. So please add QLE406xC support to RH 5. Thanks ! Trung, does the supplied patch add support for the QLE406xC though? From Dave @ QLogic:
>Yes, exactly. The ASICS is 4032 which is used on QLE406x HBA's. That is
>what the latest patches submitted are for - adding support for these
>adapters.
QE ack for RHEL5. Mike, if this is in POST, does this mean the other bugs (bug 215641 and bug 216255) should also be in POST as they are dependent bugs? I think post is for when patches are posted. I sent the orignal patch before qlogic rerolled the patches and made this patch dependent on other ones. I am in the middle of sorting out all the patches and trying to make something that applies. That is correct. you need 215641 and 216255 are need as well. in 2.6.18-1.2943.el5 Patch confirmed in 2.6.18-4.el5. Closing out. |