Bug 2138983

Summary: Review Request: rust-finl_unicode - Library for handling Unicode functionality for finl (categories and grapheme segmentation)
Product: [Fedora] Fedora Reporter: Davide Cavalca <davide>
Component: Package ReviewAssignee: Fabio Valentini <decathorpe>
Status: CLOSED NOTABUG QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: decathorpe, package-review
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-04-22 00:45:24 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 201449, 1984198    

Description Davide Cavalca 2022-10-31 20:52:56 UTC 
Spec URL: https://dcavalca.fedorapeople.org/review/rust-finl_unicode/rust-finl_unicode.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/rust-finl_unicode/rust-finl_unicode-1.2.0-1.fc38.src.rpm

Description:
Library for handling Unicode functionality for finl (categories and grapheme
segmentation).

Fedora Account System Username: dcavalca
Comment 1 Davide Cavalca 2022-10-31 20:52:58 UTC 
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=93641698
Comment 2 Fabio Valentini 2022-11-02 20:20:00 UTC 
Please remove the "criterion" dev-dependency. It is only used in benchmarks, and vastly inflates the dependency tree and build time.

It also looks like this crate contains large amounts of code that's generated from Unicode data - but the package is missing the Unicode license in its metadata and does only include this statement in its readme:

> ## Unicode copyright notice
> 
> This package incorporates data from Unicode Inc.
> Copyright © 1991–2022 Unicode, Inc. All rights reserved.
Comment 3 Package Review 2023-04-22 00:45:24 UTC 
This is an automatic action taken by review-stats script.

The ticket submitter failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we consider this ticket as DEADREVIEW and proceed to close it.