Bug 2139139

Summary: tree-wide: Use "unmet" for condition checks, not "failed"
Product: Red Hat Enterprise Linux 9 Reporter: Filip Krska <fkrska>
Component: systemdAssignee: systemd-maint
Status: CLOSED DUPLICATE QA Contact: Frantisek Sumsal <fsumsal>
Severity: medium Docs Contact:
Priority: medium    
Version: 9.0CC: dtardon, systemd-maint-list
Target Milestone: rcKeywords: EasyFix, Patch, Reproducer, Triaged
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-11-02 07:27:56 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Filip Krska 2022-11-01 15:13:45 UTC
Description of problem:

The "failed" wording confuses common checks like `journalctl --grep=failed`
and induces unnecessary investigation.



Version-Release number of selected component (if applicable):

systemd-250-7.el9

How reproducible:

always

Steps to Reproduce:
1. journalctl --grep=failed
2.
3.

Actual results:

`journalctl --grep=failed` produces many records like:

Nov 01 11:05:20 localhost systemd[1]: Load Kernel Modules was skipped because all trigger condition checks failed.
Nov 01 11:05:20 localhost systemd[1]: dracut ask for additional cmdline parameters was skipped because all trigger condition checks failed.
...
Nov 01 11:05:20 localhost systemd[1]: nm-initrd.service was skipped because of a failed condition check (ConditionPathExists=/run/NetworkManager/initrd/neednet).



Expected results:

`journalctl --grep=failed` produces no false positives



Additional info:

Reworded upstream

https://github.com/systemd/systemd/commit/413e8650b71d4404a7453403797f93d73d88c466

Comment 1 David Tardon 2022-11-02 07:27:56 UTC

*** This bug has been marked as a duplicate of bug 2137377 ***