Bug 2139546
| Summary: | libxml2 update to 2.10..3 breaks ABI by removing 111 symbols | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Dominik 'Rathann' Mierzejewski <dominik> | ||||
| Component: | libxml2 | Assignee: | David King <amigadave> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | unspecified | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | 36 | CC: | amigadave, awilliam, berrange, bgilbert, bgilbert, dustymabe, fifofonix, jlebon, mtasaka, rdieter, rjones, rrezh, veillard | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | libxml2-2.10.3-2.fc36 | Doc Type: | If docs needed, set a value | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2022-11-09 11:21:32 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 2138022 | ||||||
| Attachments: |
|
||||||
|
Description
Dominik 'Rathann' Mierzejewski
2022-11-02 22:58:18 UTC
It looks like the best way to fix this might be to rebuild --with-ftp added to %configure call. https://gitlab.gnome.org/GNOME/libxml2/-/commit/a0a0f3be93753e387e31e7de95904a24b3c876dd ImageMagick (and transitively rubygem-rmagick) is also broken So --with-ftp is only for xmlXXXXFTPXXXX series, other removed symbols are still missing. Then additionally adding --with-legacy --with-ftp --with-xptr-locs (after reading include/libxml/xmlversion.h.in, configure.ac and their histories), the result scratch build is: https://koji.fedoraproject.org/scratch/mtasaka/task_93748005/ Now: ============================================================= [tasaka1@localhost x86_64]$ rpmsodiff libxml2-2.9.14-3.fc37.x86_64.rpm libxml2-2.10.3-1.fc37.bz2139546.x86_64.rpm common sonames: libxml2.so.2 /usr/lib64/libxml2.so.2.9.14 /usr/lib64/libxml2.so.2.10.3 10 symbols removed D docbDefaultSAXHandler@@LIBXML2_2.4.30 T __docbDefaultSAXHandler T docbDefaultSAXHandlerInit@@LIBXML2_2.4.30 T initdocbDefaultSAXHandler@@LIBXML2_2.4.30 T xmlBufAddHead T xmlBufErase T xmlBufInflate T xmlBufWriteCHAR T xmlBufWriteChar T xmlSAX2InitDocbDefaultSAXHandler@@LIBXML2_2.6.0 ============================================================= 111 -> 10, but still some symbols are missing. So xmlBufAddHead, xmlBufErase, xmlBufInflate, xmlBufInflate, xmlBufWriteChar are not shown in 2.9.14 headers file, so I guess no user for these symbols (functions) exists, just libxml2 "internal" symbols are exposed. On the other hand, docbDefaultSAXHandlerInit, initdocbDefaultSAXHandler, xmlSAX2InitDocbDefaultSAXHandler are: https://gitlab.gnome.org/GNOME/libxml2/-/blob/master/libxml2.syms ... so these symbols are __really__ removed. So I think in a strict sense, 2.10.x is ABI incompatible with 2.9.14. Broken open-vm-tools: https://bugzilla.redhat.com/show_bug.cgi?id=2139849 Are we going to require that all dependent packages get rebuilt, or will we enable FTP support again in libxml2? (I am not a maintainer for libxml2, and am not familiar with libxml2 upstream policy but anyway speaking) So if FTP related symbol erasion is the only problem, so perhaps simply adding --with-ftp for libxml2 is the best, I think. But I am not confident about if that modification is really sufficient... There are "really" removed symbols on 2.10.0 (as I wrote on comment 3). https://gitlab.gnome.org/GNOME/libxml2/-/commit/4a8c71eb7cc1c9001afaeefbd454f06f5fdaa046 removed the docbook stuff. The justification was "Because of a bug in commit 961b535c, DOCBparser.c was never compiled since 2012. I couldn't find a Debian package using any of its symbols, so it seems safe to remove this module." The xmlBuf* functions were removed in https://gitlab.gnome.org/GNOME/libxml2/-/commit/fe9f76ebb8127e77cbbf25d9235ceb523d3a4a92 , claimed to be "unused". Okay, then adding "--with-legacy --with-ftp --with-xptr-locs" in libxml2 2.10.0 spec file is perhaps the safe solution. I can do a build that way if we think it's the best idea. Still, this seems like something we should discuss with upstream? It doesn't seem good if the ABI changes without the soname changing if you compile it the same way as before, right? *** Bug 2138022 has been marked as a duplicate of this bug. *** FEDORA-2022-d7349a124a has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-d7349a124a Please try with -2 , I added the options suggested by mtasaka. *** Bug 2139849 has been marked as a duplicate of this bug. *** FEDORA-2022-d7349a124a has been pushed to the Fedora 36 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-d7349a124a` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-d7349a124a See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. (In reply to Adam Williamson from comment #8) > I can do a build that way if we think it's the best idea. Still, this seems > like something we should discuss with upstream? It doesn't seem good if the > ABI changes without the soname changing if you compile it the same way as > before, right? Yes, this certainly needs to be reported upstream. A desire to be able to disable features at build time is perfectly OK, but that should never be allowed to affect the actual exported public APIs. The public API / library ABI should be invariant for any given release, regardless of build option selection. IOW, if FTP is disabled at build time, leave the FTP APIs present in the library, but stub the API implementation so it reports an error when used at runtime. Curious, a GraphicsMagick update was pushed (not me) rebuilt against the libxml2 that removed symbols. Is that GM rebuild still ok now, or does it need rebuilding again against the "fixed" libxml2? (I'm guessing it's OK, but asking for clarification) As far as I understand things I think it should be okay. Easiest thing would be to test it, though... FEDORA-2022-d7349a124a has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report. |