Bug 214106 (pear-Net-FTP)

Summary:	Review Request: php-pear-Net-FTP - Provides an OO interface to the PHP FTP functions plus some additions
Product:	[Fedora] Fedora	Reporter:	Remi Collet <fedora>
Component:	Package Review	Assignee:	Christopher Stone <chris.stone>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Package Reviews List <fedora-package-review>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	Flags:	wtogami: fedora-cvs+
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2006-11-07 16:59:12 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	163779

Description Remi Collet 2006-11-05 19:28:30 UTC

Spec URL: http://remi.collet.free.fr/rpms/extras/php-pear-Net-FTP.spec
SRPM URL: http://remi.collet.free.fr/rpms/extras/php-pear-Net-FTP-1.3.2-1.fc6.src.rpm
Mock Log: http://remi.collet.free.fr/rpms/extras/php-pear-Net-FTP-build.log
Description: 
Net_FTP allows you to communicate with FTP servers in a more comfortable
way than the native FTP functions of PHP do. The class implements everything
nativly supported by PHP and additionally features like recursive up- and
downloading, dircreation and chmodding. It although implements an observer
pattern to allow for example the view of a progress bar.


Package required by php-pear-Service-Weather, comming soon to review.

Comment 1 Christopher Stone 2006-11-06 23:03:57 UTC

==== REVIEW CHECKLIST ====
- rpmlint output clean
- packaged named according to package naming guidelines
- spec filename matches package %{name}
- spec file meets packaging guidelines
- package licensed with open source compatible license
- license matches actual license
- license file included in %doc
- spec file written in American english
- spec file is legible
- sources match upstream
fce386d6029e1171ab8f46c7568f2637  Net_FTP-1.3.2.tgz
- package successfully compiles and builds on FC5 x86_64
- All build requires listed
- no locales
- no shared libraries
- package not relocatable
- package owns all directories it creates
- file attributes set properly
- package contains proper %clean section
- macro usage is consistent
- package contains code
- no large documentation present
- files in %doc do not affect runtime
- no header files or static libraries
- no pkgconfig files
- no need for devel subpackage
- not a GUI app

APPROVED

Comment 2 Remi Collet 2007-04-29 16:36:00 UTC

Package Change Request
======================
Package Name: php-pear-Net-FTP
New Branches: EL-5