Bug 2141348

Summary:	It appears that the egg is downloaded every time
Product:	Red Hat Satellite	Reporter:	Odilon Sousa <osousa>
Component:	RH Cloud - Insights	Assignee:	Shimon Shtein <sshtein>
Status:	CLOSED ERRATA	QA Contact:	Jameer Pathan <jpathan>
Severity:	high	Docs Contact:
Priority:	high
Version:	6.9.9	CC:	ahumbe, aruzicka, vijsingh
Target Milestone:	6.9.10	Keywords:	Triaged
Target Release:	Unused
Hardware:	All
OS:	Unspecified
Whiteboard:
Fixed In Version:	rubygem-foreman_rh_cloud-3.0.33	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	2141308	Environment:
Last Closed:	2022-11-17 17:17:17 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Odilon Sousa 2022-11-09 14:28:17 UTC

+++ This bug was initially created as a clone of Bug #2141308 +++

Description of problem:

I am seeing around 100k downloads per hour. This leads me to believe that the client is downloading this information to do any sort of "should I refresh" logic instead of using some server side check. 


Expected results:

Ideally, if these files are not changed then the files are not downloaded.

Additional info:

Comment 1 Jameer Pathan 2022-11-10 15:17:10 UTC

Verified:

Verified with:
- Satellite 6.9.10 snap 2
- tfm-rubygem-foreman_rh_cloud-3.0.33-1.el7sat.noarch

Test steps:
- Register Satellite content host with insights.
- Run "insights-client" on the content host.
- Check /var/log/foreman/production.log on Satellite for insights-core.egg download requests.

Observations:
- Satellite 6.9 is now sending etag to https://cert-api.access.redhat.com/r/insights/v1/static/release/insights-core.egg
- response `304 NotModified` is returned from the server(meaning that client has the latest insights egg, so no need to re-download it).

Additional info:

---
On client:
# cat /etc/insights-client/.insights-core.etag
"e454bc2ccc068771c9fc3e7668adbeb2:1667486431.027061"

# insights-client --version
Client: 3.1.7
Core: 3.0.302-1

# insights-client --net-debug
** trimmed output **
GET https://satellite.example.com:443/redhat_access/r/insights/v1/static/release/insights-core.egg
GET https://satellite.example.com:443/redhat_access/r/insights/v1/static/release/insights-core.egg
HTTP Status: 304 Not Modified
** trimmed output **

---
Satellite production.log:
** trimmed output **
2022-11-10T08:30:48 [I|app|60b8af11] Started GET "/redhat_access/r/insights/v1/static/release/insights-core.egg" for <ip-address> at 2022-11-10 08:30:48 -0500
2022-11-10T08:30:49 [I|app|60b8af11] Processing by InsightsCloud::Api::MachineTelemetriesController#forward_request as
2022-11-10T08:30:49 [I|app|60b8af11]   Parameters: {"path"=>"v1/static/release/insights-core"}
2022-11-10T08:30:49 [D|tax|60b8af11] Current location set to none
2022-11-10T08:30:49 [D|tax|60b8af11] Current organization set to none
2022-11-10T08:30:49 [D|app|60b8af11] Request parameters for telemetry request: {"branch_id"=>"99e683c4-79fc-4be6-8384-e0ff48a7eb7e"}
2022-11-10T08:30:49 [D|app|60b8af11] User agent for telemetry is: Foreman/2.3.1.25;foreman_rh_cloud/3.0.33;insights-client/3.1.7 (Core 3.0.302; requests 2.20.0) Red Hat Enterprise Linux 8.6 (CPython 3.6.8; Linux 4.18.0-372.32.1.el8_6.x86_64); systemd
2022-11-10T08:30:49 [D|app|60b8af11] Sending headers: {:if_none_match=>"\"e454bc2ccc068771c9fc3e7668adbeb2:1667486431.027061\""}
2022-11-10T08:30:49 [D|app|60b8af11] Sending request to: https://cert-api.access.redhat.com/r/insights/v1/static/release/insights-core.egg
2022-11-10T08:30:49 [D|app|60b8af11] RestClient.get "https://cert-api.access.redhat.com/r/insights/v1/static/release/insights-core.egg?branch_id=99e683c4-79fc-4be6-8384-e0ff48a7eb7e", "Accept"=>"*/*", "Accept-Encoding"=>"gzip, deflate", "Content-Type"=>"#<Mime::NullType:0x000000001f2ffc50>", "If-None-Match"=>"\"e454bc2ccc068771c9fc3e7668adbeb2:1667486431.027061\"", "User-Agent"=>"Foreman/2.3.1.25;foreman_rh_cloud/3.0.33;insights-client/3.1.7 (Core 3.0.302; requests 2.20.0) Red Hat Enterprise Linux 8.6 (CPython 3.6.8; Linux 4.18.0-372.32.1.el8_6.x86_64); systemd"
 60b8af11 |
2022-11-10T08:30:49 [D|app|60b8af11] # => 304 NotModified | application/zip 0 bytes
 60b8af11 |
2022-11-10T08:30:49 [I|app|60b8af11] Completed 304 Not Modified in 117ms (Views: 0.5ms | ActiveRecord: 1.7ms | Allocations: 5110)
** trimmed output **

Comment 7 errata-xmlrpc 2022-11-17 17:17:17 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: Satellite 6.9.10 Async Security Update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:8532