Bug 2143047

Summary:	Hard dependency on package cockpit-ws breaks Podman implementation of cockpit-ws
Product:	[Fedora] Fedora	Reporter:	Martín Cigorraga <martincigorraga>
Component:	cockpit-file-sharing	Assignee:	Orphan Owner <extras-orphan>
Status:	NEW ---	QA Contact:
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	37	CC:	sgallagh
Target Milestone:	---
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:		Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Martín Cigorraga 2022-11-15 21:53:03 UTC

Description of problem:
(What follows is a copy & paste of my original report on 45Drives' GitHub repository)

The RPM package for cockpit-file-sharing installs cockpit-ws as a dependency, which conflicts with the Podman-based deployment, as described in https://github.com/cockpit-project/cockpit-container

Version-Release number of selected component (if applicable):
OS: Fedora IoT 36 and 37
Cockpit Version: 277-1 (Fedora 37) and 278-1 (Fedora 36)

How reproducible:
Always.

Steps to Reproduce:
1. `rpm-ostree install cockpit-file-sharing`
2. `podman container runlabel --name cockpit-ws RUN quay.io/cockpit/ws`
3. See error

Note: this error occurs with the cockpit-file-sharing version shipped with both Fedora IoT 36 and 37, as well as with the RPM package available in this repository (see details below)

Actual results:
Podman will be unable to spin a Cockpit container

Expected results:
The installation of package `cockpit-file-sharing` shouldn't interfere with the way you install and run Cockpit

Additional info:
The issue described above happens with both cockpit-file-sharing version 2.4.5-2 (from the Fedora IoT 36 and 37 official repositories), and with version 3.2.9-2 available here.

Why does cockpit-file-sharing enforce cockpit-ws as a dependency?

From what I saw from all other Cockpit applications, none of them has cockpit-ws as a hard dependency.

45Drives reply: https://github.com/45Drives/cockpit-file-sharing/issues/62#issuecomment-1313954951

Thanks!

Comment 1 Stephen Gallagher 2022-11-16 20:35:53 UTC

I can drop the hard dependency. I wasn't aware of this use-case and it seemed to me that it wasn't terribly useful without the web interface, but that was a faulty assumption.

That said, I haven't had much time for this package recently (and upstream did a significant rewrite/refactor for the 3.x series), so it may be a while before I can get to it. If you want to submit a merge request at https://src.fedoraproject.org/rpms/cockpit-file-sharing, I will happily review it and merge it if appropriate.

Comment 2 Martín Cigorraga 2022-11-16 20:42:49 UTC

Hi Stephen,

Sounds good! I'll take a look at it, it shouldn't be hard at all (famous last words...)

Comment 3 Martín Cigorraga 2022-11-16 21:50:13 UTC

I hit an unrelated issue at build time with a missing NPM package when looking to try out my changes: https://github.com/45Drives/cockpit-file-sharing/issues/64

I'll keep you posted.

Comment 4 Fedora Admin user for bugzilla script actions 2023-08-12 00:11:01 UTC

This package has changed maintainer in Fedora. Reassigning to the new maintainer of this component.