Bug 2143573

Summary: fftw2: Avoid implicit function declaration during build
Product: [Fedora] Fedora Reporter: Florian Weimer <fweimer>
Component: fftw2Assignee: Florian Weimer <fweimer>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: jamatos, jplesnik, lkundrak
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: fftw2-2.1.5-44.fc38 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-11-17 09:28:41 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2141798    

Description Florian Weimer 2022-11-17 09:24:30 UTC
fftw2 is unsupported upstream: last release 1999, maintenance has switch to version fftw 3. Therefore, we need to apply a custom patch to avoid C89isms.

diff --git a/configure b/configure
index f5bab28675937533..5af49397a60b4811 100755
--- a/configure
+++ b/configure
@@ -4459,8 +4459,8 @@ main ()
   for (i = 0; i < 256; i++)
     if (XOR (islower (i), ISLOWER (i))
         || toupper (i) != TOUPPER (i))
-      exit(2);
-  exit (0);
+      return 2;
+  return 0;
 }
 _ACEOF
 rm -f conftest$ac_exeext

This check seems to have been built into earlier autoconf versions, so the patch will likely be required elsewhere, too.