Bug 2144758

Summary: FTBFS with autoconf 2.72
Product: [Fedora] Fedora Reporter: Frédéric Bérat <fberat>
Component: celestiaAssignee: Mattia Verga <mattia.verga>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: mkreder, sam, steve
Target Milestone: ---Keywords: FutureFeature
Target Release: ---   
Hardware: Unspecified   
OS: All   
Whiteboard:
Fixed In Version: celestia-1.7.0~20230305ebfcdb1-2.fc39 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-03-05 16:28:36 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2143303    

Description Frédéric Bérat 2022-11-22 09:01:00 UTC
Autoconf 2.72 seems to be under preparation upstream, I therefore started to build dependent components to verify that they can be built once it lands in Fedora.

Your component fails to build with the new version of autoconf, due to the following error:

---
checking for GTK... yes
Using config source xml:merged:/etc/gconf/gconf.xml.defaults for schema installation
Using $(sysconfdir)/gconf/schemas as install directory for schema files
checking for CAIRO... yes
./configure: line 30733: syntax error near unexpected token `fi'
./configure: line 30733: `fi'
error: Bad exit status from /var/tmp/rpm-tmp.KDCW4H (%build)
    Bad exit status from /var/tmp/rpm-tmp.KDCW4H (%build)
RPM build errors:
Child return code was: 1
---

The error is due to a misplace 'fi' in acinclude.m4.

The proposed patch is the following:
---
diff -r -U5 Celestia-1.6.2-beta3.old/acinclude.m4 Celestia-1.6.2-beta3/acinclude.m4
--- Celestia-1.6.2-beta3.old/acinclude.m4	2022-11-22 09:54:34.759349238 +0100
+++ Celestia-1.6.2-beta3/acinclude.m4	2022-11-22 09:54:43.836371600 +0100
@@ -2628,12 +2628,12 @@
             eval "kde_cv_qt_jpeg=no",
             eval "kde_cv_qt_jpeg=yes")
 LIBS="$ac_save_LIBS"
 CXXFLAGS="$ac_save_CXXFLAGS"
 AC_LANG_RESTORE
-fi
 ])
+fi
 
 if eval "test ! \"`echo $kde_cv_qt_jpeg`\" = no"; then
   AC_MSG_RESULT(yes)
   LIBJPEG_QT='$(LIBJPEG)'
 else
---

Please have a look and get it fixed upstream.

Comment 1 Fedora Admin user for bugzilla script actions 2022-11-29 00:07:01 UTC
This package has changed maintainer in Fedora. Reassigning to the new maintainer of this component.

Comment 2 Mattia Verga 2022-11-29 09:01:18 UTC
I'm trying to update celestia to the latest git snapshot, it will get rid of autotools.

Comment 3 Fedora Update System 2023-03-05 16:26:07 UTC
FEDORA-2023-361e30a2ff has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-361e30a2ff

Comment 4 Fedora Update System 2023-03-05 16:28:36 UTC
FEDORA-2023-361e30a2ff has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.