Bug 2145125

Summary:	pep8 job fails due to bad pre-commit configuration
Product:	Red Hat OpenStack	Reporter:	Szymon Datko <sdatko>
Component:	python-automaton	Assignee:	OSP Team <rhos-maint>
Status:	NEW ---	QA Contact:	Nobody <nobody>
Severity:	low	Docs Contact:
Priority:	unspecified
Version:	17.0 (Wallaby)	CC:	amoralej, apevec, jschluet, lhh, lsvaty
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:		Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Szymon Datko 2022-11-23 09:59:44 UTC

Hello,

there is an issue with the pep8 we run as part of Component CI for OSP 17.0 and OSP 17.1

The problem is, the project uses git pre-commit hooks as part of pep8 tox environment and specifies the old, not existing anymore repository of flake8, which was recently moved from GitLab to GitHub.

Some details: https://www.reddit.com/r/Python/comments/yvfww8/flake8_took_down_the_gitlab_repository_in_favor/

Yours, Szymon

Comment 1 Szymon Datko 2022-11-23 10:03:17 UTC

In-job workaround with sed was implemented for now: https://github.com/RedHatCRE/znoyder/pull/112

But in case of developers running the tests locally, the fix in downstream source code shall be implemented.

Note: the issue is also present in upstream wallaby https://opendev.org/openstack/automaton/src/branch/stable/wallaby/.pre-commit-config.yaml but was recently fixed in master https://review.opendev.org/c/openstack/automaton/+/782440