Bug 2145241

Summary: a little problem in label probe wildcard expansion
Product: Red Hat Enterprise Linux 8 Reporter: Martin Cermak <mcermak>
Component: systemtapAssignee: Ryan Goldberg <rgoldber>
systemtap sub component: system-version QA Contact: Martin Cermak <mcermak>
Status: CLOSED ERRATA Docs Contact:
Severity: unspecified    
Priority: unspecified CC: fche, lberk, mcermak, mjw, wcohen
Version: 8.6Keywords: Regression, Triaged
Target Milestone: rcFlags: pm-rhel: mirror+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: systemtap-4.8-2.el8 Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-05-16 08:30:10 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Martin Cermak 2022-11-23 15:21:00 UTC
systemtap-4.8-1.el8 doesn't correctly expand wildcards in label probes.  Problem description taken from PR29676:

Commit d922f3166 seems to have an unwanted side-effect related to labels.  The upstream testsuite has testcase labels.exp that started to fail with it.  From the user perspective the problem is that now stap -l (or -L) can return something like this:

process("/somedir/labels.x").function("_start").label("*")
process("/somedir/labels.x").function("deregister_tm_clones").label("*")
process("/somedir/labels.x").function("foo@/somedir/labels.c:5").label("init_an_int")

Note the label("*") in the above output. The star is a wildcard which should have been expanded, not printed out. Also the function pnlabel() can now start returning star, while, again, this is a wildcard that should have been expanded instead of returned.

Comment 1 William Cohen 2022-11-23 21:21:53 UTC
Rolled back to git commit a50bb747070b4bd592f3c32d5e83e4b508c6d8d7 (commit just before the change to wild card change).  See

$ sudo make installcheck RUNTESTFLAGS="--debug systemtap.base/labels.exp"
....
		=== systemtap Summary ===

# of expected passes		10

For git commit 92e8ecb3329820992756bbbd3decd3d2ef4f490a see:

$ sudo make installcheck RUNTESTFLAGS="--debug systemtap.base/labels.exp"
....
		=== systemtap Summary ===

# of expected passes		8
# of unexpected failures	2

Comment 2 Martin Cermak 2023-01-13 16:55:44 UTC
Verified using labels.exp.

Comment 6 errata-xmlrpc 2023-05-16 08:30:10 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (systemtap bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2023:2799