Bug 2148733

Summary: dmraid: Build fixes for C99 compilers
Product: [Fedora] Fedora Reporter: Florian Weimer <fweimer>
Component: dmraidAssignee: LVM and device-mapper development team <lvm-team>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: agk, bmr, cfeist, heinzm, kzak, lvm-team, mcsontos, prajnoha, prockai, zkabelac
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: dmraid-1.0.0.rc16-54.fc38 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-11-27 15:51:59 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2141798    
Attachments:
Description Flags
dmraid C99 fix
none
dmraid-c99.patch none

Description Florian Weimer 2022-11-27 15:40:26 UTC
Created attachment 1927836 [details]
dmraid C99 fix

It looks like Fedora is the de-facto upstream for this package, so reporting the bug here. A small fix is needed to build the sources with a compiler that does not support implicit ints.

Comment 1 Florian Weimer 2022-11-27 15:51:59 UTC
I'm closing this bug after applying the patch to rawhide, under the assumption that this patch is not needed anywhere else.

Comment 2 Florian Weimer 2023-11-22 14:11:07 UTC
Created attachment 2000905 [details]
dmraid-c99.patch

Updated patch with -Wreturn-mismatch fix.