Bug 2148854

Summary: Please backport: [PATCH] teamd: do no remove the ports on shutdown with -N
Product: Red Hat Enterprise Linux 9 Reporter: Lubomir Rintel <lrintel>
Component: libteamAssignee: Xin Long <lxin>
Status: CLOSED ERRATA QA Contact: LiLiang <liali>
Severity: high Docs Contact:
Priority: high    
Version: 9.1CC: lrintel, mleitner, network-qe
Target Milestone: rcKeywords: Triaged
Target Release: 9.2Flags: pm-rhel: mirror+
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: libteam-1.31-16.el9_1 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 2148856 (view as bug list) Environment:
Last Closed: 2023-01-23 15:23:31 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2148856    

Description Lubomir Rintel 2022-11-28 07:34:59 UTC
Please backport the following upstream commit:

dbb2cfc teamd: do no remove the ports on shutdown with -N

https://github.com/jpirko/libteam/commit/dbb2cfca35d2cd15125eb84e8f3940f8cc3ea860

This fixes handover from initrd to real root (without this teamd would deconfigure the ports in between).

Thank you!

Comment 6 LiLiang 2022-12-08 02:21:20 UTC
Tested

[root@dell-per740-17 ~]# teamd -d -N
This program is not intended to be run as root.
[root@dell-per740-17 ~]# ip link set team0 up
[root@dell-per740-17 ~]# ip link set ens1f0np0 down
[root@dell-per740-17 ~]# ip link set ens1f1np1 down
[root@dell-per740-17 ~]# teamdctl team0 port add ens1f0np0
[root@dell-per740-17 ~]# teamdctl team0 port add ens1f1np1
[root@dell-per740-17 ~]# dhclient -v team0
Internet Systems Consortium DHCP Client 4.4.2b1
Copyright 2004-2019 Internet Systems Consortium.
All rights reserved.
For info, please visit https://www.isc.org/software/dhcp/

grep: /etc/sysconfig/network-scripts/ifcfg-*: No such file or directory
grep: /etc/sysconfig/network-scripts/ifcfg-*: No such file or directory
grep: /etc/sysconfig/network-scripts/ifcfg-*: No such file or directory
Listening on LPF/team0/b8:59:9f:06:56:6c
Sending on   LPF/team0/b8:59:9f:06:56:6c
Sending on   Socket/fallback
DHCPDISCOVER on team0 to 255.255.255.255 port 67 interval 6 (xid=0x94d4994c)
DHCPOFFER of 192.168.2.201 from 192.168.1.253
DHCPREQUEST for 192.168.2.201 on team0 to 255.255.255.255 port 67 (xid=0x94d4994c)
DHCPACK of 192.168.2.201 from 192.168.1.253 (xid=0x94d4994c)
grep: /etc/sysconfig/network-scripts/ifcfg-*: No such file or directory
grep: /etc/sysconfig/network-scripts/ifcfg-*: No such file or directory
grep: /etc/sysconfig/network-scripts/ifcfg-*: No such file or directory
bound to 192.168.2.201 -- renewal in 3379 seconds.
[root@dell-per740-17 ~]# ping 192.168.1.253 -I team0
PING 192.168.1.253 (192.168.1.253) from 192.168.2.201 team0: 56(84) bytes of data.
64 bytes from 192.168.1.253: icmp_seq=1 ttl=64 time=0.273 ms
64 bytes from 192.168.1.253: icmp_seq=1 ttl=64 time=0.288 ms (DUP!)
64 bytes from 192.168.1.253: icmp_seq=2 ttl=64 time=0.207 ms
64 bytes from 192.168.1.253: icmp_seq=2 ttl=64 time=0.218 ms (DUP!)
^C
--- 192.168.1.253 ping statistics ---
2 packets transmitted, 2 received, +2 duplicates, 0% packet loss, time 1023ms
rtt min/avg/max/mdev = 0.207/0.246/0.288/0.034 ms
[root@dell-per740-17 ~]# teamd -k -t team0
[root@dell-per740-17 ~]# ip link show team0
73: team0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc noqueue state UP mode DEFAULT group default qlen 1000
    link/ether b8:59:9f:06:56:6c brd ff:ff:ff:ff:ff:ff
[root@dell-per740-17 ~]# ip link show ens1f0np0
6: ens1f0np0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc mq master team0 state UP mode DEFAULT group default qlen 1000
    link/ether b8:59:9f:06:56:6c brd ff:ff:ff:ff:ff:ff
    altname enp59s0f0np0
[root@dell-per740-17 ~]# ip link show ens1f1np1
7: ens1f1np1: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc mq master team0 state UP mode DEFAULT group default qlen 1000
    link/ether b8:59:9f:06:56:6c brd ff:ff:ff:ff:ff:ff permaddr b8:59:9f:06:56:6d
    altname enp59s0f1np1
[root@dell-per740-17 ~]# ping 192.168.1.253 -I team0
PING 192.168.1.253 (192.168.1.253) from 192.168.2.201 team0: 56(84) bytes of data.
64 bytes from 192.168.1.253: icmp_seq=1 ttl=64 time=0.221 ms
64 bytes from 192.168.1.253: icmp_seq=1 ttl=64 time=0.220 ms (DUP!)
64 bytes from 192.168.1.253: icmp_seq=2 ttl=64 time=0.194 ms
^C
--- 192.168.1.253 ping statistics ---
2 packets transmitted, 2 received, +1 duplicates, 0% packet loss, time 1026ms
rtt min/avg/max/mdev = 0.194/0.211/0.221/0.012 ms
[root@dell-per740-17 ~]# ip link del team0
[root@dell-per740-17 ~]# ip link show team0
Device "team0" does not exist.
[root@dell-per740-17 ~]# ip link show ens1f0np0
6: ens1f0np0: <BROADCAST,MULTICAST> mtu 1500 qdisc mq state DOWN mode DEFAULT group default qlen 1000
    link/ether b8:59:9f:06:56:6c brd ff:ff:ff:ff:ff:ff
    altname enp59s0f0np0
[root@dell-per740-17 ~]# ip link show ens1f1np1
7: ens1f1np1: <BROADCAST,MULTICAST> mtu 1500 qdisc mq state DOWN mode DEFAULT group default qlen 1000
    link/ether b8:59:9f:06:56:6d brd ff:ff:ff:ff:ff:ff
    altname enp59s0f1np1

[root@dell-per740-17 ~]# rpm -q teamd
teamd-1.31-16.el9_1.x86_64
[root@dell-per740-17 ~]# rpm -q libteam
libteam-1.31-16.el9_1.x86_64

Comment 12 errata-xmlrpc 2023-01-23 15:23:31 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (libteam bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2023:0344