Bug 2148856

Summary: Please backport: [PATCH] teamd: do no remove the ports on shutdown with -N
Product: Red Hat Enterprise Linux 8 Reporter: Lubomir Rintel <lrintel>
Component: libteamAssignee: Xin Long <lxin>
Status: CLOSED ERRATA QA Contact: LiLiang <liali>
Severity: high Docs Contact:
Priority: high    
Version: 8.7CC: liali, lxin, network-qe
Target Milestone: rcKeywords: Triaged
Target Release: 8.8   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: libteam-1.31-4.el8 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 2148854 Environment:
Last Closed: 2023-05-16 09:03:11 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 2148854    
Bug Blocks:    

Description Lubomir Rintel 2022-11-28 07:41:00 UTC
+++ This bug was initially created as a clone of Bug #2148854 +++

Please backport the following upstream commit:

dbb2cfc teamd: do no remove the ports on shutdown with -N

https://github.com/jpirko/libteam/commit/dbb2cfca35d2cd15125eb84e8f3940f8cc3ea860

This fixes handover from initrd to real root (without this teamd would deconfigure the ports in between).

Thank you!

Comment 1 LiLiang 2022-12-07 01:53:49 UTC
Tested

[root@dell-per740-17 ~]# teamd -d -N
This program is not intended to be run as root.
[root@dell-per740-17 ~]# ip link set team0 up
[root@dell-per740-17 ~]# ip link set ens1f0 down
[root@dell-per740-17 ~]# ip link set ens1f1 down
[root@dell-per740-17 ~]# teamdctl team0 port add ens1f0
[root@dell-per740-17 ~]# teamdctl team0 port add ens1f1
[root@dell-per740-17 ~]# dhclient -v team0
Internet Systems Consortium DHCP Client 4.3.6
Copyright 2004-2017 Internet Systems Consortium.
All rights reserved.
For info, please visit https://www.isc.org/software/dhcp/

Listening on LPF/team0/b8:59:9f:06:56:6c
Sending on   LPF/team0/b8:59:9f:06:56:6c
Sending on   Socket/fallback
DHCPREQUEST on team0 to 255.255.255.255 port 67 (xid=0x68e7747d)
DHCPACK from 192.168.1.253 (xid=0x68e7747d)
bound to 192.168.1.62 -- renewal in 3490 seconds.
[root@dell-per740-17 ~]# ping 192.168.1.253 -I team0
PING 192.168.1.253 (192.168.1.253) from 192.168.1.62 team0: 56(84) bytes of data.
64 bytes from 192.168.1.253: icmp_seq=1 ttl=64 time=0.229 ms
64 bytes from 192.168.1.253: icmp_seq=1 ttl=64 time=0.293 ms (DUP!)
64 bytes from 192.168.1.253: icmp_seq=2 ttl=64 time=0.188 ms
64 bytes from 192.168.1.253: icmp_seq=2 ttl=64 time=0.189 ms (DUP!)
^C
--- 192.168.1.253 ping statistics ---
2 packets transmitted, 2 received, +2 duplicates, 0% packet loss, time 1013ms
rtt min/avg/max/mdev = 0.188/0.224/0.293/0.046 ms
[root@dell-per740-17 ~]# teamd -k -t team0
[root@dell-per740-17 ~]# ip link show team0
8: team0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc noqueue state UP mode DEFAULT group default qlen 1000
    link/ether b8:59:9f:06:56:6c brd ff:ff:ff:ff:ff:ff
[root@dell-per740-17 ~]# ip link show ens1f0
6: ens1f0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc mq master team0 state UP mode DEFAULT group default qlen 1000
    link/ether b8:59:9f:06:56:6c brd ff:ff:ff:ff:ff:ff
[root@dell-per740-17 ~]# ip link show ens1f1
7: ens1f1: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc mq master team0 state UP mode DEFAULT group default qlen 1000
    link/ether b8:59:9f:06:56:6c brd ff:ff:ff:ff:ff:ff permaddr b8:59:9f:06:56:6d
[root@dell-per740-17 ~]# ping 192.168.1.253 -I team0
PING 192.168.1.253 (192.168.1.253) from 192.168.1.62 team0: 56(84) bytes of data.
64 bytes from 192.168.1.253: icmp_seq=1 ttl=64 time=0.188 ms
64 bytes from 192.168.1.253: icmp_seq=1 ttl=64 time=0.200 ms (DUP!)
64 bytes from 192.168.1.253: icmp_seq=2 ttl=64 time=0.201 ms
64 bytes from 192.168.1.253: icmp_seq=2 ttl=64 time=0.213 ms (DUP!)
^C
--- 192.168.1.253 ping statistics ---
2 packets transmitted, 2 received, +2 duplicates, 0% packet loss, time 1050ms
rtt min/avg/max/mdev = 0.188/0.200/0.213/0.016 ms
[root@dell-per740-17 ~]# ip link set ens1f0 nomaster
[root@dell-per740-17 ~]# ping 192.168.1.253 -I team0
PING 192.168.1.253 (192.168.1.253) from 192.168.1.62 team0: 56(84) bytes of data.
64 bytes from 192.168.1.253: icmp_seq=1 ttl=64 time=0.203 ms
64 bytes from 192.168.1.253: icmp_seq=2 ttl=64 time=0.153 ms
^C
--- 192.168.1.253 ping statistics ---
2 packets transmitted, 2 received, 0% packet loss, time 1052ms
rtt min/avg/max/mdev = 0.153/0.178/0.203/0.025 ms
[root@dell-per740-17 ~]# ip link del team0
[root@dell-per740-17 ~]# ip link show ens1f0
6: ens1f0: <BROADCAST,MULTICAST> mtu 1500 qdisc mq state DOWN mode DEFAULT group default qlen 1000
    link/ether b8:59:9f:06:56:6c brd ff:ff:ff:ff:ff:ff
[root@dell-per740-17 ~]# ip link show ens1f1
7: ens1f1: <BROADCAST,MULTICAST> mtu 1500 qdisc mq state DOWN mode DEFAULT group default qlen 1000
    link/ether b8:59:9f:06:56:6d brd ff:ff:ff:ff:ff:ff
[root@dell-per740-17 ~]# rpm -q teamd
teamd-1.31-4.el8.x86_64
[root@dell-per740-17 ~]# rpm -q libteam
libteam-1.31-4.el8.x86_64

Comment 6 LiLiang 2022-12-08 00:45:40 UTC
set verified according to comment #2

Comment 8 errata-xmlrpc 2023-05-16 09:03:11 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (libteam bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2023:2956