Bug 2148940

Summary: BitchX: Work around C99 compatibility issues
Product: [Fedora] Fedora Reporter: Florian Weimer <fweimer>
Component: BitchXAssignee: kevin_redhat
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: kevin_redhat, rdieter
Target Milestone: ---Keywords: Reopened
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: BitchX-1.2.1-33.fc40 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-01-15 11:01:51 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2137516    
Attachments:
Description Flags
BitchX-configure-c99.patch
none
BitchX-acro-c99.patch
none
BitchX-aim-c99.patch none

Description Florian Weimer 2022-11-28 11:49:24 UTC
Created attachment 1928004 [details]
BitchX-configure-c99.patch

To build with future compiler versions, we need to make Fedora packages compatible with stricter C99 build modes. Upstream is largely dormant, so filing this bug for tracking purposes. I found a bunch of upstream patches we can use, only the configure updates are custom.

Comment 1 Florian Weimer 2024-01-04 18:19:34 UTC
This needs many more fixes for GCC 14 compatibility.  Some of them are already in dist-git, but the AIM plugin needs a few more changes. I'm attaching a new version of that, and fixes for the acro plugin.

I do not plan to spend more time on this.

Comment 2 Florian Weimer 2024-01-04 18:19:55 UTC
Created attachment 2007207 [details]
BitchX-acro-c99.patch

Comment 3 Florian Weimer 2024-01-04 18:20:32 UTC
Created attachment 2007208 [details]
BitchX-aim-c99.patch

Comment 4 Florian Weimer 2024-01-15 11:01:51 UTC
I downgraded the C type safety level instead.