Bug 2149671

Summary:	[4.10] Backup program integration: DataVolume/PVC restore should not require PVC initially owned by DV
Product:	Container Native Virtualization (CNV)	Reporter:	Michael Henriksen <mhenriks>
Component:	Storage	Assignee:	Michael Henriksen <mhenriks>
Status:	CLOSED ERRATA	QA Contact:	Yan Du <yadu>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	4.10.0	CC:	alitke, ngavrilo, yadu
Target Milestone:	---
Target Release:	4.10.8
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	v4.10.8-8	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	2149669	Environment:
Last Closed:	2023-03-14 16:09:32 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	2149669
Bug Blocks:

Description Michael Henriksen 2022-11-30 14:53:34 UTC

+++ This bug was initially created as a clone of Bug #2149669 +++

Description of problem:

When a DataVolume/PVC is being restored by a backup program (say Velero) the following should be true:

1.  DataVolume has "cdi.kubevirt.io/storage.prePopulated" annotation
2.  PVC has "cdi.kubevirt.io/storage.populatedFor" annotation
3.  Doesn't matter if DV or PVC is restored first
4.  PVC does not have to initially be owned by the DataVolume

This bug deals with 4


Version-Release number of selected component (if applicable):  4.10.X


How reproducible:


Steps to Reproduce:
1.  Create DataVolume

apiVersion: cdi.kubevirt.io/v1beta1
kind: DataVolume
metadata:
  annotations:
    cdi.kubevirt.io/storage.prePopulated: populated-dv
  name: populated-dv
  namespace: default
spec:
  pvc:
    accessModes:
    - ReadWriteOnce
    resources:
      requests:
        storage: 2Gi
    storageClassName: rook-ceph-block
    volumeMode: Filesystem
  source:
    http:
      url: http://doesnotexist/disk.img

2. Create PVC

apiVersion: v1
kind: PersistentVolumeClaim
metadata:
  annotations:
    cdi.kubevirt.io/storage.populatedFor: populated-dv
  name: populated-dv
  namespace: default
spec:
  accessModes:
  - ReadWriteOnce
  resources:
    requests:
      storage: 2Gi
  storageClassName: rook-ceph-block
  volumeMode: Filesystem


Actual results:

DataVolume will stay pending until DV is reconciled again 


Expected results:

DataVolume will go to succeeded phase


Additional info:

Comment 3 Yan Du 2023-01-12 03:17:52 UTC

Test on OCP-4.10.48 + CNV v4.10.8-8, issue have been fixed.

$ oc get dv
NAME           PHASE       PROGRESS   RESTARTS   AGE
populated-dv   Succeeded   N/A                   24s

Comment 9 errata-xmlrpc 2023-03-14 16:09:32 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (OpenShift Virtualization 4.10.8 Images), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2023:1233