Bug 2150032

Summary: abidiff is taking a very long time on /usr/bin/ld.gold and /usr/bin/dwp
Product: Red Hat Enterprise Linux 9 Reporter: David Cantrell <dcantrell>
Component: libabigailAssignee: Dodji Seketeli <dodji>
Status: CLOSED MIGRATED QA Contact: Martin Cermak <mcermak>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: unspecifiedCC: mprchlik, msrb, sipoyare, wcohen
Target Milestone: rcKeywords: MigratedToJIRA, Triaged
Target Release: ---Flags: pm-rhel: mirror+
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-09-22 15:58:24 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 2152553    
Bug Blocks:    

Description David Cantrell 2022-12-01 16:52:27 UTC
When running rpminspect to compare binutils-2.35.2-24.el9 to binutils-2.35.2-26.el9, the abidiff inspection gets hung up on /usr/bin/ld.gold and /usr/bin/dwp and has taken up to 8 hours before ever completing.

Configuring rpminspect to exclude these two files from the abidiff run causes rpminspect to complete as expected.

More information is here:
https://issues.redhat.com/browse/OSCI-4219

Comment 1 William Cohen 2022-12-01 19:21:07 UTC
On Fedora 36 machine with following rpms see libagigail getting stuck on ld.gold:

rpminspect-1.11-0.1.202211231559git683d045.fc36.x86_64
libabigail-2.1-1.fc36.x86_64

With the following:

rpminspect -v -T abidiff -a x86_64 -w $(pwd)/tmp binutils-2.35.2-24.el9  binutils-2.35.2-26.el9 -c /usr/share/rpminspect/redhat.yaml


After 9 minutes of runtime I killed the abidiff that was running for ld.gold.  It continue on to processing dwp, but libabigail completed processing dwp.

One question that crossed my mind was whether the fixes for rhbz2134960 in libabigail-2.2 to speed up processing of firefox libraries address this problem?
I installed a locally built version of libabigail-2.2-1.el9.src.rpm and reran.  The rpminspect command completed in a reasonable amount of time on a F36 machine.

Comment 5 Dodji Seketeli 2022-12-02 21:59:39 UTC
OK, t(In reply to William Cohen from comment #1)
> On Fedora 36 machine with following rpms see libagigail getting stuck on
> ld.gold:
> 
> rpminspect-1.11-0.1.202211231559git683d045.fc36.x86_64
> libabigail-2.1-1.fc36.x86_64
> 
> With the following:
> 
> rpminspect -v -T abidiff -a x86_64 -w $(pwd)/tmp binutils-2.35.2-24.el9 
> binutils-2.35.2-26.el9 -c /usr/share/rpminspect/redhat.yaml
> 
> 
> After 9 minutes of runtime I killed the abidiff that was running for
> ld.gold.  It continue on to processing dwp, but libabigail completed
> processing dwp.
> 
> One question that crossed my mind was whether the fixes for rhbz2134960 in
> libabigail-2.2 to speed up processing of firefox libraries address this
> problem?
> I installed a locally built version of libabigail-2.2-1.el9.src.rpm and
> reran.  The rpminspect command completed in a reasonable amount of time on a
> F36 machine.


Thank you Will!

I have made an upstream 2.2 release containing all the latest fixes including the ones for rhbz2134960.  The release notes are available at https://inbox.sourceware.org/libabigail/87o7slsd5o.fsf@redhat.com.

In case someone is interested, here is a centos 9 scratch-build for that release: https://kojihub.stream.rdu2.redhat.com/koji/taskinfo?taskID=1648613.

At this point, I think we can tout the idea of an EL 9.2 rebase to libabigail 2.2, if that scratch-build improves things.

Comment 6 RHEL Program Management 2023-09-22 15:55:36 UTC
Issue migration from Bugzilla to Jira is in process at this time. This will be the last message in Jira copied from the Bugzilla bug.

Comment 7 RHEL Program Management 2023-09-22 15:58:24 UTC
This BZ has been automatically migrated to the issues.redhat.com Red Hat Issue Tracker. All future work related to this report will be managed there.

Due to differences in account names between systems, some fields were not replicated.  Be sure to add yourself to Jira issue's "Watchers" field to continue receiving updates and add others to the "Need Info From" field to continue requesting information.

To find the migrated issue, look in the "Links" section for a direct link to the new issue location. The issue key will have an icon of 2 footprints next to it, and begin with "RHEL-" followed by an integer.  You can also find this issue by visiting https://issues.redhat.com/issues/?jql= and searching the "Bugzilla Bug" field for this BZ's number, e.g. a search like:

"Bugzilla Bug" = 1234567

In the event you have trouble locating or viewing this issue, you can file an issue by sending mail to rh-issues. You can also visit https://access.redhat.com/articles/7032570 for general account information.