Bug 2150036

Summary:	Review Request: perl-Alien-Font-Uni - Access to Unifont TrueType file
Product:	[Fedora] Fedora	Reporter:	Petr Pisar <ppisar>
Component:	Package Review	Assignee:	Michal Josef Spacek <mspacek>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	mspacek, package-review
Target Milestone:	---	Flags:	mspacek: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	perl-Alien-Font-Uni-0.3-1.fc39	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-05-25 11:06:27 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Petr Pisar 2022-12-01 17:11:34 UTC

Spec URL: https://ppisar.fedorapeople.org/perl-Alien-Font-Uni/perl-Alien-Font-Uni.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Alien-Font-Uni/perl-Alien-Font-Uni-0.3-1.fc38.src.rpm
Description:
This module was created as an optional dependency of Chart to have access to
a Unicode-complete scaleable font file. Thus only the Unifont TTF file is
provided since this is what GD can read.

Fedora Account System Username: ppisar

Comment 1 Michal Josef Spacek 2023-05-22 12:29:51 UTC

There are some issues:
* Alien::Font::Uni wants *ttf files, but unifont-fonts delivers *otf fonts (which is installed by 'font(unifont)'. There is unifont-ttf-fonts package.
* Remove "File::ShareDir::Install" => "0.06" from configure options in Makefile.PL by existing patch
* Remove BuildRequires with COMPAT

Comment 2 Petr Pisar 2023-05-23 12:45:53 UTC

Thanks for highlighting the issues. All should be addressed now.

Spec URL: https://ppisar.fedorapeople.org/perl-Alien-Font-Uni/perl-Alien-Font-Uni.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Alien-Font-Uni/perl-Alien-Font-Uni-0.3-1.fc39.src.rpm

Comment 3 Michal Josef Spacek 2023-05-24 09:44:42 UTC

Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Alien-Font-Uni-0.3-1.fc39.noarch.rpm | sort | uniq -c | grep -v rpmlib
      1 perl-libs
      1 perl(strict)
      1 perl(version) >= 0.77
      1 unifont-ttf-fonts
Binary requires are Ok.

$ rpm -qp --provides perl-Alien-Font-Uni-0.3-1.fc39.noarch.rpm | sort | uniq -c
      1 perl(Alien::Font::Uni) = 0.3
      1 perl-Alien-Font-Uni = 0.3-1.fc39
Binary provides are Ok.

$ rpmlint ./perl-Alien-Font-Uni*
3 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.2 s
perl-Alien-Font-Uni-tests.noarch: W: no-documentation
Rpmlint is ok

The package is in line with Fedora and Perl packaging guide lines.

Comment 4 Fedora Admin user for bugzilla script actions 2023-05-24 14:27:51 UTC

The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Alien-Font-Uni

Comment 5 Petr Pisar 2023-05-24 14:31:33 UTC

Thank you for the review.